fix(ckeditor): preserve summary and aria-* in Text plugin HTML - #1180
Merged
Conversation
html5lib drops <summary> and aria-* on save; teach CKEditor 4 DTD for summary only.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
wesleyboar
added a commit
that referenced
this pull request
Jul 13, 2026
## Overview Sortable tables get sort buttons and optional JS-built filter UI via [`@tacc/html-filter-sort`](https://github.com/wesleyboar/Core-HTML-Filter-Sort); `assets_core_delayed.html` loads the package from jsDelivr CDN. ## Related - [RT #42216](https://tickets.tacc.utexas.edu/Ticket/Display.html?id=42216) - mimicked by TACC/tup-ui#558 <details> - requires - #1180 - https://github.com/wesleyboar/Core-HTML-Filter-Sort - improves #1167 - simplified by #1202 - simplified by #1203 </details> ## Changes - **deleted** `sortableTable.js`, `sortableTable.css`, `sortable_table_filter_templates.html`, and the orphaned `modules/sortableTable.html` demo doc (referenced the deleted CSS file and pre-rename API names) - **updated** `assets_core_delayed.html` to load [`@tacc/html-filter-sort`](https://github.com/wesleyboar/Core-HTML-Filter-Sort) JS and CSS from the npm CDN (package renamed twice: `sort-table` → `filter-sort` → `html-filter-sort`; now on npm instead of a pinned commit SHA), and pass `buttonClass` so sort buttons pick up Core-Styles' link-button class - **updated** `tmp/pr-1169.html` to use `data-filtersort-search` and `data-filtersort-select-cols` (current library API; supersedes the `data-sortable-*` names used in earlier iterations) ## Testing 1. Open `tmp/pr-1169.html` with a local static server. 2. Confirm sort, search, column selects, and result count update. 3. After deploy, any page with delayed core assets gets the filter UI from `@tacc/html-filter-sort`. ## UI Screenshots: pending upload --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Text plugin saves were turning
<summary>into escaped text and strippingaria-*because html5lib’s default allowlist includes<details>but not<summary>or WAI-ARIA attributes. This adds the minimum server and editor hooks so disclosure markup survives save and reload.Changes
<summary>for some aspect<summary>for another aspectaria-attributesTesting
make start(or use runningcore_cms).?edit, add or edit a Text plugin.<summary>is still a tag (not<summary>).aria-*attributes remain.UI
before.mov
after.mov
Tip
I tested
aria-too (andclassandid), just didn't video that.