feat(sortableTable): auto-build filters - #1178
Merged
Merged
Conversation
Tables with data-sortable-filters get a cloned fieldset before init; shared template ships via delayed assets and tup-ui snippet.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Filter labels keep abbr and other header HTML; fallback to JSON label or column name when the th is empty.
wesleyboar
changed the title
… npm package (#1202) ## Overview Migrate `sortableTable.*` and `<template>` to new new [`@tacc/sortable-table`](https://github.com/wesleyboar/sortable-table) npm package. Core-CMS becomes a CDN consumer via jsDelivr. ## Related - [`wesleyboar/sortable-table`](https://github.com/wesleyboar/sortable-table) (the new package) - simplifies #1178 - mimicked by TACC/tup-ui#563 ## Changes - **deleted** `sortableTable.*` and template - **updated** `assets_core_delayed.html` - **deleted** `{% include %}` cuz package self-injects it now ## Notes > [!IMPORTANT] > jsDelivr SHA pin (`df4d78b8`) will be updated to a versioned npm URL after `@tacc/sortable-table@0.1.0` is published. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
## Overview Updates demo files to use the new `data-sortable-search` / `data-sortable-select-cols` attribute API and bumps the CDN pin to `wesleyboar/sort-table@e63f5427`. ## Related - updates #1178 - mimics TACC/tup-ui#564 - requires wesleyboar/Core-HTML-Filter-Sort#3 ## Changes - **replaced** `data-sortable-filters` JSON with `data-sortable-search` and `data-sortable-select-cols` in demo files - **deleted** inline `<template>` from `tmp/pr-1169.html` (JS self-injects) - **updated** CDN pin from `wesleyboar/sortable-table@fb956d9f` to `wesleyboar/sort-table@e63f5427` ## Notes > [!IMPORTANT] > jsDelivr SHA pin will be updated to a versioned npm URL after `@tacc/sort-table@0.1.0` is published. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Package renamed @tacc/sort-table -> @tacc/filter-sort (PR #11): file renamed sortableTable.js -> filtersort.js, sortableTable.css -> filtersort.css, exported fn sortableTable() -> filtersort().
Package (renamed from sort-table/filter-sort) is now published to npm; use the versioned jsDelivr npm URL instead of the pinned GH SHA.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Jul 11, 2026
Package (renamed from sort-table/filter-sort) is now published to npm; use the versioned jsDelivr npm URL instead of the pinned GH SHA. Keeps this snippet in sync with TACC/Core-CMS#1178.
… files - assets_core_delayed.html: pass buttonClass (Core-Styles link-button class) to filtersort(), matching tup-ui's equivalent snippet - tmp/pr-1169.html: point at the @tacc/html-filter-sort CDN package and use its current js-filtersort class / data-filtersort-* attrs, instead of stale local files and pre-rename API names - delete modules/sortableTable.html: orphaned usage doc for the local sortableTable.js/.css module already deleted by this PR; it still linked the removed CSS file and used attribute names two renames out of date. Usage docs now live in the package README.
The Core-Styles bootstrap4 alert component CSS isn't used by the table markup, and it's already loaded elsewhere in Core-Styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Sortable tables get sort buttons and optional JS-built filter UI via
@tacc/html-filter-sort;assets_core_delayed.htmlloads the package from jsDelivr CDN.Related
Details
Changes
sortableTable.js,sortableTable.css,sortable_table_filter_templates.html, and the orphanedmodules/sortableTable.htmldemo doc (referenced the deleted CSS file and pre-rename API names)assets_core_delayed.htmlto load@tacc/html-filter-sortJS and CSS from the npm CDN (package renamed twice:sort-table→filter-sort→html-filter-sort; now on npm instead of a pinned commit SHA), and passbuttonClassso sort buttons pick up Core-Styles' link-button classtmp/pr-1169.htmlto usedata-filtersort-searchanddata-filtersort-select-cols(current library API; supersedes thedata-sortable-*names used in earlier iterations)Testing
tmp/pr-1169.htmlwith a local static server.@tacc/html-filter-sort.UI
interactive.table.mov