Skip to content

fix(clippy): drop LSP large futures and hotpath needless return #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 2 commits into from
Sep 9, 2026
Merged

fix(clippy): drop LSP large futures and hotpath needless return #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7bd8b0
fix(lsp): box the measured analyzer request future
ScriptedAlchemy Sep 9, 2026
0ba77eb
fix(daemon): drop needless return in hotpath watchdog
ScriptedAlchemy Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/tracedecay-lsp/src/analyzer/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,11 @@ impl StdioLspClient {
where
R: LspRequest,
{
let response = self.request::<R>(params, cancellation, timeouts).await?;
// Boxed: with profiling enabled `request` is the widest I/O future in
// this client. Awaiting it by value inflates every semantic wrapper
// and the dispatch match (a match future is as large as its widest
// arm).
let response = Box::pin(self.request::<R>(params, cancellation, timeouts)).await?;
serde_json::to_value(response).map_err(|error| LspSemanticRequestError::InvalidResponse {
class: error.to_string(),
})
Expand Down
2 changes: 1 addition & 1 deletion crates/tracedecay/src/daemon/shutdown_watchdog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ fn finalize_hotpath_report_within(bound: Duration) {
fn watchdog_fire_after() -> Duration {
#[cfg(feature = "hotpath")]
{
return shutdown_exit_bound().saturating_sub(HOTPATH_FINALIZE_BOUND);
shutdown_exit_bound().saturating_sub(HOTPATH_FINALIZE_BOUND)
}
#[cfg(not(feature = "hotpath"))]
shutdown_exit_bound()
Expand Down
Loading