fix(clippy): drop LSP large futures and hotpath needless return - #1137
Open
ScriptedAlchemy wants to merge 2 commits into
Open
fix(clippy): drop LSP large futures and hotpath needless return#1137ScriptedAlchemy wants to merge 2 commits into
ScriptedAlchemy wants to merge 2 commits into
Conversation
Awaiting request by value inflates every semantic wrapper and the dispatch match past large_futures once the hotpath backend is unified.
The hotpath arm of watchdog_fire_after is already the function's value; return trips clippy::needless_return when that feature is on.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestfuture at therequest_jsonboundary so hotpath unification no longer inflates 24 semantic wrappers pastlarge_futuresreturnin the hotpath arm ofwatchdog_fire_afterUnblocks dependency-inclusive clippy for sibling #1073 lanes.
Verification
clippy -p tracedecay-lsp --all-targets --all-features: 0/0clippy -p tracedecay --all-targets --features hotpath: 0/0 (was 24large_futures+ 1needless_return)clippy -p tracedecay-maintenance -p tracedecay-mcp --all-targets --all-features: 0/0tracedecay-lsptests: 216 lib + 49 integration