Repository navigation
Require an adversarial review and a clean rehearsal before infrastructure PRs - #6
Merged
Merged
Conversation
10 tasks done
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a rule to
AGENTS.md: before an infrastructure change opens its pull request, independent read-only reviewers check it, and it is rehearsed from nothing. The reviewers cover security, containers and proxy, shell portability, and acceptance coverage. The rehearsal ismake reset, thenmake bootstrapandmake upon a clean checkout.It comes from the retro on #2: those two checks found what the step-by-step checks missed, including Valkey running without a password on a network it shared with the proxy (D-13).
Docs only. To roll back, revert this PR.