Repository navigation
A person's change puts a folder where a file stands and a file where an empty folder stands - #265
Merged
Merged
Conversation
…an empty folder stands Codex's read-only review of #264 (c76a4c4): - placement.ts realTarget judges a path below a file (ENOTDIR) as it judges a path not there (ENOENT): by what is there. So restoring historical sub/a.md where sub is now a file passes the link check, and the change's deletion of the file comes first. - An empty folder where a file is written, which git does not hold and no deletion names, is removed first (rmdir, which refuses a folder that is not empty). Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the fixes for Codex's read-only review of #264 (c76a4c4), one commit on staging c76a4c4.
sub/a.mdwheresubis now a file threwENOTDIRinthroughNoLink, before the deletions ranplacement.tsrealTargetjudges a path below a file (ENOTDIR) as it judges a path not there (ENOENT): by what is therermdir, which refuses one that is not empty)Size: production 2 files, +4/−1; test +10.
Gates