Skip to content

A major-1 drama converts even with turns or paid calls left unsettled in 0.2.6, and names them - #258

Merged
SitgesRun merged 1 commit into
stagingfrom
w04/convert-unsettled
Nov 15, 2026
Merged

SitgesRun merged 1 commit into
stagingfrom
w04/convert-unsettled

Conversation

@SitgesRun

Copy link
Copy Markdown
Contributor

Once Pine runs the major-2 tools, a 0.2.6 turn with no return, or a major-1 paid call not settled, can never settle. Refusing until 0.2.6 settled them left such a drama unconvertible. The conversion now goes on and names them.

  • convertMajor1ProjectToMajor2 no longer refuses for an unreturned turn or an unsettled paid call. It returns { backup, unsettled }. unsettled holds:
    • each turn this profile sent and dealt with no return of, whose return the folder's turns/ doesn't hold;
    • each version whose paid call is in no settled state of the table, with its state.
  • projectCommands.ts names each one after converting, in a warning: their results can't be recovered, and Pine may already have charged for them. The wording is "may" because an unsettled call can be of unknown outcome.
  • The backup takes the first free name: <name>.backup-<date>, then -2, -3… (placement.ts unusedName). A backup of the same day no longer refuses. cp's errorOnExist still refuses a target made meanwhile.
  • Kept: the refusal for a folder with no record of its turns. Opening it once in 0.2.6 writes them, with no Pine needed.
  • doc/protocol.md section 7 and the conversion table's paid_call_settled note say the same.

Deleted

  • The unreturned-turn refusal.
  • refuseWhileAPaidCallIsNotSettled.
  • The "backup already exists" refusal.
  • The two refusal tests, which are now one test of what converts and is named.

Tests

  • New: a 0.2.6 turn with no return and paid calls not settled are converted as found and named. A turn whose return the folder holds, and settled calls (rejected, lost), are not named.
  • Changed: a backup name already taken gives -2.
  • Failing first: the same tests, cast to compile against the old signature, on staging 44fbc06 (run 20261115T224000-f5e57195). The new test fails with the old refusal: "Nothing was changed. A turn sent from Pine Drama Studio 0.2.6 has not returned yet…". The backup test fails on the old "already exists" refusal.

Verification

  • pine-dev on the exact head 16d141977677 (staging 627cb22): run 20261115T224605-16d14197, done: PASSED in 96s. npm test 335 tests, 0 failures, 1 skipped; render smoke 30 of 30 pages.
  • npx tsc: no error in the changed files. The local check uses an older node_modules, so its 8 errors elsewhere come from that.
  • Codex, read-only:
    • On the plan, which gave the table note, the softer charge wording and the folder-held returns.
    • On the code: no findings. An earlier mkdir reservation of the backup name broke every conversion, because fs.cp with errorOnExist refuses an existing directory. The pine-dev gate caught it, and it is removed here.

… in 0.2.6, and names them

Once Pine runs the major-2 tools, a 0.2.6 turn with no return or a major-1 paid call
not settled can never settle, so refusing until 0.2.6 settles it left the drama
unconvertible. The conversion now goes on and returns what was left unsettled; the
Studio names each one when it is done, says its results can't be recovered and that
Pine may already have charged for it. The backup takes the first free name, so a
backup of the same day no longer refuses either. The refusal for a folder with no
record of its turns stays: opening it once in 0.2.6 writes them, with no Pine needed.
Protocol section 7 and the conversion table's note say the same.

Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
@SitgesRun
SitgesRun merged commit 16d1419 into staging Nov 15, 2026
1 check passed
@SitgesRun
SitgesRun deleted the w04/convert-unsettled branch November 15, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant