Repository navigation
A major-1 drama converts even with turns or paid calls left unsettled in 0.2.6, and names them - #258
Merged
Merged
Conversation
… in 0.2.6, and names them Once Pine runs the major-2 tools, a 0.2.6 turn with no return or a major-1 paid call not settled can never settle, so refusing until 0.2.6 settles it left the drama unconvertible. The conversion now goes on and returns what was left unsettled; the Studio names each one when it is done, says its results can't be recovered and that Pine may already have charged for it. The backup takes the first free name, so a backup of the same day no longer refuses either. The refusal for a folder with no record of its turns stays: opening it once in 0.2.6 writes them, with no Pine needed. Protocol section 7 and the conversion table's note say the same. Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once Pine runs the major-2 tools, a 0.2.6 turn with no return, or a major-1 paid call not settled, can never settle. Refusing until 0.2.6 settled them left such a drama unconvertible. The conversion now goes on and names them.
convertMajor1ProjectToMajor2no longer refuses for an unreturned turn or an unsettled paid call. It returns{ backup, unsettled }.unsettledholds:turns/doesn't hold;projectCommands.tsnames each one after converting, in a warning: their results can't be recovered, and Pine may already have charged for them. The wording is "may" because an unsettled call can be of unknown outcome.<name>.backup-<date>, then-2,-3… (placement.tsunusedName). A backup of the same day no longer refuses.cp'serrorOnExiststill refuses a target made meanwhile.doc/protocol.mdsection 7 and the conversion table'spaid_call_settlednote say the same.Deleted
refuseWhileAPaidCallIsNotSettled.Tests
rejected,lost), are not named.-2.Verification
16d141977677(staging 627cb22): run 20261115T224605-16d14197,done: PASSED in 96s. npm test 335 tests, 0 failures, 1 skipped; render smoke 30 of 30 pages.npx tsc: no error in the changed files. The local check uses an oldernode_modules, so its 8 errors elsewhere come from that.mkdirreservation of the backup name broke every conversion, becausefs.cpwitherrorOnExistrefuses an existing directory. The pine-dev gate caught it, and it is removed here.