Skip to content

Revert #255 (A10): the endings' event-id compare-and-set is withdrawn before the release - #256

Merged
SitgesRun merged 1 commit into
stagingfrom
revert/a10-255
Nov 15, 2026
Merged

SitgesRun merged 1 commit into
stagingfrom
revert/a10-255

Conversation

@SitgesRun

Copy link
Copy Markdown
Contributor

Reverts #255 before the release.

The person does not want the event-id compare-and-set on a turn's endings. A10 will be redone after the release with one writer, as Claude Agent SDK and codex-rs do it:

  • the Stop only sends the cancel;
  • the follower records endings from Pine's ordered events, following past needs_input until the question is answered or a later terminal result arrives.

The RCA, the plan and the Reload Window workaround are in the A10 issue.

  • git revert 6497b7e. The tree is identical to 44fbc06 (git diff 44fbc06 HEAD is empty).
  • The store schema is back to 20, with no step 21.
  • A store at 21 would be refused as written by a newer Studio. Checked:
    • no tag or release contains 6497b7e;
    • all 21 studio.sqlite files on the development Mac are at schema 20 or older;
    • on pine-dev, the stores written since the merge are all test-run temporaries.

Gate, pine-dev on this exact head 627cb222fb8ae6f1d1548fe9d6a150bdbab35572: npm test: tests 336, pass 335, fail 0, skipped 1; render smoke 30 of 30; release safety tests passed.

… before the release

This reverts commit 6497b7e.

The person does not want a sequence compare on a turn's endings (chats.ending_event_id, Store.recordEnding, schema step 21): it adds a second ordering rule beside the follower. A10 is to be redone after the release the way Claude Agent SDK and codex-rs do it, with one writer:
- the Stop only sends the cancel;
- the follower records a turn's ending from Pine's ordered events, following past needs_input until the question is answered or a later terminal result (such as "question canceled") arrives.

The A10 issue holds the RCA and that plan; until then Reload Window recovers the Chat.

The store's schema goes back to 20, with no step 21. A store at 21 would be refused as written by a newer Studio. Checked on 2026-11-15:
- no tag or release contains 6497b7e;
- every Studio store on the development Mac (21 studio.sqlite files, release and dev profiles) is at schema 20 or older;
- on pine-dev, the stores written since the merge are all test-run temporaries (~/test-runs/studio/*/tmp).

Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
@SitgesRun
SitgesRun merged commit 627cb22 into staging Nov 15, 2026
1 check passed
@SitgesRun
SitgesRun deleted the revert/a10-255 branch November 15, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant