Repository navigation
Revert #255 (A10): the endings' event-id compare-and-set is withdrawn before the release - #256
Merged
Merged
Conversation
… before the release This reverts commit 6497b7e. The person does not want a sequence compare on a turn's endings (chats.ending_event_id, Store.recordEnding, schema step 21): it adds a second ordering rule beside the follower. A10 is to be redone after the release the way Claude Agent SDK and codex-rs do it, with one writer: - the Stop only sends the cancel; - the follower records a turn's ending from Pine's ordered events, following past needs_input until the question is answered or a later terminal result (such as "question canceled") arrives. The A10 issue holds the RCA and that plan; until then Reload Window recovers the Chat. The store's schema goes back to 20, with no step 21. A store at 21 would be refused as written by a newer Studio. Checked on 2026-11-15: - no tag or release contains 6497b7e; - every Studio store on the development Mac (21 studio.sqlite files, release and dev profiles) is at schema 20 or older; - on pine-dev, the stores written since the merge are all test-run temporaries (~/test-runs/studio/*/tmp). Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #255 before the release.
The person does not want the event-id compare-and-set on a turn's endings. A10 will be redone after the release with one writer, as Claude Agent SDK and codex-rs do it:
needs_inputuntil the question is answered or a later terminal result arrives.The RCA, the plan and the Reload Window workaround are in the A10 issue.
git revert 6497b7e. The tree is identical to44fbc06(git diff 44fbc06 HEADis empty).Gate, pine-dev on this exact head
627cb222fb8ae6f1d1548fe9d6a150bdbab35572:npm test: tests 336, pass 335, fail 0, skipped 1; render smoke 30 of 30; release safety tests passed.