Skip to content

tuning.ts and canvasLayout.ts say what the code does; the commit id shown and the token estimate are named - #247

Merged
SitgesRun merged 1 commit into
stagingfrom
fix/tuning-comments
Nov 15, 2026
Merged

SitgesRun merged 1 commit into
stagingfrom
fix/tuning-comments

Conversation

@SitgesRun

@SitgesRun SitgesRun commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Fix-forward for #245, from Codex's read-only review of its landed head 6db79ac. Codex found no behaviour regression and four Low findings, all fixed here. Behaviour is unchanged.

The findings and their fixes

  1. tuning.ts, canvas layout section.
    • Finding: "an arranged board keeps its places" was too strong. positionsFor runs stepAway on arranged boards, so a larger card or pad moves the cards and frames it would make overlap.
    • Fix: the comment now says that a card or frame another now covers steps away (Codex's second pass caught that the first wording had it backwards).
  2. tuning.ts, COLLECT_EVERY_MS.
    • Finding: "Each collection is one exec" was wrong. fetchCapture runs a second exec to remove the fetched bundle (turn.ts).
    • Fix: the comment now says only that a collection runs by exec.
  3. canvasLayout.ts, groupLayout.
    • Finding: the comment called every other card of an asset group a variant. A scene's group also holds the scenes inside it (assetsCanvas.ts, inside_of).
    • Fix: the comment now says that, ordered by column, then id.
  4. Two Studio choices were still written inline.
    • projectViews.ts: the Versions tooltip's 12 characters of a commit id are now COMMIT_ID_SHOWN.
    • pineSessions.ts: provideTokenCount's 4 characters per token are now CHARS_PER_TOKEN. The rule of thumb is from OpenAI's help article "What are tokens and how to count them?".

Tests

  • npx tsc -p . locally: no errors beyond the main checkout's known dugite/TS7006 artifacts.
  • Suite: scripts/test-on-pine-dev.sh studio a01a6205990327b7d73e1bc6fb3f587cdfbff4ff (on staging 6db79ac): PASSED in 96 s. npm test: tests 329, pass 328, fail 0, skipped 1; render smoke: 30 of 30 pages; release safety tests passed.
  • Codex read-only on 5e970e8: one Low finding (the stepAway direction), fixed in a01a620 with Codex's own wording; no other findings.

…rd steps away, a collection is not one exec, an asset group holds a scene's interiors; the commit id shown and the token estimate are named

Codex's read-only review of #245. An arranged board's cards and frames step away from what a larger card or pad
makes them cover (canvasLayout.ts stepAway), so a changed layout number moves them too. A collection removes its
fetched bundle with a second exec (turn.ts fetchCapture). A scene's group on the assets canvas also holds the scenes
inside it (assetsCanvas.ts inside_of). The Versions tooltip's 12 characters and the 4 characters per token are the
Studio's choices and are named in tuning.ts. Behaviour is unchanged.

Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
@SitgesRun
SitgesRun merged commit a01a620 into staging Nov 15, 2026
1 check passed
@SitgesRun
SitgesRun deleted the fix/tuning-comments branch November 15, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant