Repository navigation
tuning.ts and canvasLayout.ts say what the code does; the commit id shown and the token estimate are named - #247
Merged
Merged
Conversation
…rd steps away, a collection is not one exec, an asset group holds a scene's interiors; the commit id shown and the token estimate are named Codex's read-only review of #245. An arranged board's cards and frames step away from what a larger card or pad makes them cover (canvasLayout.ts stepAway), so a changed layout number moves them too. A collection removes its fetched bundle with a second exec (turn.ts fetchCapture). A scene's group on the assets canvas also holds the scenes inside it (assetsCanvas.ts inside_of). The Versions tooltip's 12 characters and the 4 characters per token are the Studio's choices and are named in tuning.ts. Behaviour is unchanged. Signed-off-by: SitgesRun <169425442+SitgesRun@users.noreply.github.com>
SitgesRun
force-pushed
the
fix/tuning-comments
branch
from
November 15, 2026 21:14
5e970e8 to
a01a620
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for #245, from Codex's read-only review of its landed head 6db79ac. Codex found no behaviour regression and four Low findings, all fixed here. Behaviour is unchanged.
The findings and their fixes
tuning.ts, canvas layout section.positionsForrunsstepAwayon arranged boards, so a larger card or pad moves the cards and frames it would make overlap.tuning.ts,COLLECT_EVERY_MS.fetchCaptureruns a second exec to remove the fetched bundle (turn.ts).canvasLayout.ts,groupLayout.assetsCanvas.ts,inside_of).projectViews.ts: the Versions tooltip's 12 characters of a commit id are nowCOMMIT_ID_SHOWN.pineSessions.ts:provideTokenCount's 4 characters per token are nowCHARS_PER_TOKEN. The rule of thumb is from OpenAI's help article "What are tokens and how to count them?".Tests
npx tsc -p .locally: no errors beyond the main checkout's known dugite/TS7006 artifacts.scripts/test-on-pine-dev.sh studio a01a6205990327b7d73e1bc6fb3f587cdfbff4ff(on staging 6db79ac): PASSED in 96 s. npm test: tests 329, pass 328, fail 0, skipped 1; render smoke: 30 of 30 pages; release safety tests passed.