Repository navigation
[Tests] Preserve void-module checks across instance printing forms - #366
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
12 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #363 changes normal
ac.instanceprinting from the quoted generic name to an unquoted operation name. The void-module tests added in #364 then count zero child instances and fail three cases. Accept both spellings while retaining exact callee, two-instance and zero-result assertions.Change type
Related issues
Related to #363 and #361. This is a prerequisite integration repair for #363; #364 is already merged. It does not close #361.
Changes
Tests/System owner: adjust two text filters in
tests/system/test_void_module_results.py. No compiler, DUT, runtime, backend or semantic contract changes.Validation
PASS: changed-file
SKIP=pyc-api-hygiene pre-commit run --files tests/system/test_void_module_results.py(Ruff, Black and text checks), exit 0;git diff --check, exit 0.Reproduced on [IR] 建立规范化资源接口与事务阶段契约 #363 b69202a plus main da1e315: three void-module tests fail with 0 rather than 2 detected instances.
PASS after this exact two-line fix:
python -m pytest -q tests/system/test_void_module_results.py, 30/30, exit 0, on integration commit 19fcf70b3a00e32ac47dbb7e723dfd438cdb0aac. Compiler rebuilt and installed in that checkout with LLVM/MLIR 22.1.8; generated C++/Verilog execution remains in the existing tests.Adapter commit: 271c707; local raw integration evidence:
docs/gates/logs/20261027-review-pr363/void-before.logandvoid-after.log. These are local records; the results above are the remotely readable summary.NOT RUN: nightly and long matrices, outside this two-line test adaptation.
Executed checks and outcomes are recorded above
Skipped, deferred or unavailable checks and reasons are recorded above
Review checklist
Reviewer notes
Independent native reviewer inspected the integration candidate and before/after evidence: clear. Implementation and review were separate instances; reviewer inherited session model/effort with no override. Remote CI is pending. No new hardware capability is claimed; ordinary child execution assertions remain unchanged. This separate prerequisite is needed because the #363 fork disallows maintainer edits and the current account has no fork write access.