Repository navigation
Conversation
Capture PR-07 resource interfaces, SSA and Method constraints, PR-08 Queue execution, and PR-09 composition examples with their tests and design records. Include native transactional CI coverage and the current common-analysis refactor.
Persist formal read identity and authored payload evaluation through source publication and branch joins. Resolve reached-path consumption in common analysis, remove cached reads, and require source contract 4 artifacts. Share callable return normalization and representation constructors, use a common read-only constant proof, and replace repeated dependency scans with stable ready processing. Extend independent resource and return histories. Validation: affected C++ workers 1/2, Verilog, four-state and supported t-gfsim regressions pass; independent review, changed-file pre-commit and strict docs build pass. Full API/examples gates retain baseline-reproduced failures; nightly not run. Controlled routing measurement showed no speedup.
Integrate main 3d37651 without restoring deleted importers or superseded v2 boundary fixtures. Retain evolved normalized contracts, Linked continuation, common aggregate availability, Queue proposals and Bits width checks. Static-parameter Method checks remain in retained common legacy consumers, not a frontend support claim. Validation: rebuilt current compiler; baseline 13 transactional/display cases and native runtime passed. Changed-file pre-commit and strict docs passed. Initial integrated run identifies void direct-call reference gap, addressed next. Full API and examples gates fail on retained migration inputs; no nightly claim. Local integration only.
Void Module calls now bind a non-payload reference to their actual allocation, preserving aliases and distinct children without dummy ports. Migrate void coverage to interface-only source publication, saved Linked continuation and independent old-Q histories on C++ workers 1/2, RTL and t-gfsim. Replace redundant legacy IR-shape and rejection matrices with four public zero-payload export cases. Validation: 14 transactional/display lit tests pass; four pure void export cases pass; changed-file Ruff/Black/pre-commit pass. Pure roots retain compiler-owned clock/reset inputs; the previous no-domain expectation is not claimed. Broader legacy gates and static/Table migrations remain open.
Build generated-System examples through their emitted CMake project instead of inventing a translation unit per Python source. Preserve declaration-only and Rule-only units. Document migrated void behavior, retained common fixes, removed coverage and pending static-parameter/Table capabilities. Validation: 10 current System example targets build and execute successfully; final 14 transactional/display lit tests, runtime/hardware checks, focused aggregate checks, pre-commit and strict docs pass. Complete API/example gates still FAIL on retained legacy migration inputs; five static Method cases and full Table pool remain FAIL at admission. Full nightly NOT RUN. Independent implementation review clear; evidence docs/gates/logs/20261029-issue361-main-integration/.
…ations Check transactional body assertions on every Work evaluation with ordinary reset masking in physical backends and t-gfsim. Preserve independent low-epoch failure and rollback histories; add normalized resource anchor and interface publication checks and a named main-capability migration inventory. Retire only the obsolete legacy summary-forgery matrix. Validation: 14 transactional/display lit PASS; 15 current saved-anchor checks PASS; two normalized native anchor checks PASS. Changed-file pre-commit and strict MkDocs PASS. Full API and examples gates retain documented migration failures; remaining legacy native failures and original nominal/report oracle remain open. Related to #361.
Publish symbolic Module/System parameters and defer payload/Method constraints until Link binds actual instances using shared static evaluation. Preserve independent state, dependent defaults, root overrides, static operands and Queue depth through saved Linked continuation; validate unused/default-bound bodies and retain source provenance. Validation: final12 parameter/Method cases PASS across C++ workers1/2 and RTL;14 transactional/display lit PASS;15 saved-anchor regressions PASS; full resource_composition example PASS. Native Routed/runtime PASS; retained native Anchor15/interface148 failures and full gate migration failures remain explicit. Ruff/Black and strict docs PASS. Independent compiler and Astra authoring/oracle review clear. Related to #361; depends on9b398d0d.
zhoubot
requested changes
Oct 29, 2026
zhoubot
left a comment
zhoubot
left a comment
Contributor
There was a problem hiding this comment.
The staged transactional path has useful passing evidence, but this candidate is not ready to replace main. Please restore compatible capabilities before merge; the requested acceptance boundary is to keep this PR open until that work is complete.
P1: compiler/lib/Compiler/PythonImportRecords.cpp:723–728 rejects ordinary pure helpers on the sole production frontend. A minimal typed def twice(value: ac.u8) -> ac.u8: return value + value, called from an @ac.module, compiles with PR #322/main's frontend but fails here with transactional source functions require module/system/rule decoration. This also blocks the helper-based numerical providers in #322. Ordinary helpers are retained migration obligations in main-capability-migration.md batch 3, not cancelled semantics. Restore them through the owning importer/common analysis with source-unit/header authority and independent native/RTL evidence; do not add a fallback compiler or remove coverage.
Fresh local build from this exact head with LLVM/MLIR 22.1.8: native transaction Runtime CTest 1/1 PASS; all 14 focused transactional/display lit tests PASS; independent Python boundary checks 105 PASS. Separate physical/runtime review found no additional actionable issue in its inspected scope. However bash tools/run_api_tests.sh --tier gate exits 1 while compiling retained module_loop, and bash tools/run_examples.sh --tier gate exits 1 at multi_outputs (Module payload outputs require a Rule result). These failures preserve the original registry. Full nightly and cross-platform acceptance were NOT RUN. Hosted G0/G1 success does not resolve these full-gate failures.
Independent review reports were produced by separate gpt-6.1-sol instances for core and physical/runtime paths; local raw commands/results are under docs/gates/logs/pr-review-20261030/. No whole-migration or merge-ready claim.
Merged
11 tasks done
Capture static range loops as Source SCF and expand occurrence-private bodies after parameter binding. Preserve local values, resource connections, instance identities and transaction boundaries through common analysis. Add dual-backend loop, reset, failure and saved-artifact coverage; migrate queue_rule_pipeline and document the bounded profile. Validation: 11 focused lit regressions, queue pipeline execution, changed-file pre-commit, strict MkDocs and independent review pass. Aggregate API/examples gates and retained legacy-contract tests still fail; full acceptance is not claimed.
Separate packed Array payloads from component Table references and bump the source contract to 5. Add Table capture, member linking, selected transaction analysis, static traversal, independent histories and a dispatch example. Validation: 18 transactional lit tests, 12 bounded parameter/Method tests, 271 unit tests, dual backend Table scenarios and example, pinned changed-file hooks and strict docs passed. Retained legacy module_loop aggregate build and two legacy dependency tests remain failing; full nightly not run.
…wering Related: #361. Make catalog tiers distinguish verified executable designs from pending work, migrate sibling histories and retain partial example migrations and oracles. Defer further ROB repairs at the user's request. Separate physical storage lowering from the old transaction materializer, remove legacy executable routing and obsolete analysis selectors, and retire selected superseded tests while retaining shared validation and private APIs still needed by mixed native tests. Fix payload constraints, bounded dependency/replay traversal, lossless saved provenance and deterministic artifact loading, and configured-libdir packaging. Validation: focused native/lit regressions and independent reviews recorded under docs/gates/logs/; 15 example nightly cases passed before the final proof cache optimizations; catalog 20/20, installed artifact/runtime tests 3/3, changed-file pre-commit and strict docs checks passed. Full API acceptance is not green (18/26 targets on the recorded candidate); ROB execution is deferred, full picker backend acceptance and remaining legacy cleanup are unfinished. Other agents' two pre-existing edits and ppt_pipeline are excluded. Evidence is from the shared worktree, not a claim of isolated clean-commit acceptance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
本 PR 将生产前端替换为 issue #361 的事务级 ACIR：Python capture → Source → Linked → 公共事务分析 → Routed → 物理存储 lowering → C++/Verilog。Module 管结构、状态和组合计算，Rule 管原子事务，Method 提供同拍调用接口；普通 Rule 显式注册，状态读取遵循 old Q。
当前提交：
e3355f02367f14d61bdf97ccc4fe289e6bcb7067。替换尚未完成，完整 API 验收仍有失败，PR 保持开放，不声明可合并。本次相对远程原 head
c36a973a94222c7c4cc64fdebf95b31b2fbc2741新增一个提交，80 文件，+2,494/-1,826 行，净增 668 行；其中包含物理 lowering 搬移、文档与迁移清单。ROB 按用户要求暂缓进一步修复，保留源码、完整历史和独立 oracle，不计入通过集合。Change type
Related issues
Related to #361、#319，不关闭这些 issue。语义依据为 issue #361、已批准的 Struct/Bits 部分更新契约和仓库 transactional replacement plan。#363–#367 是已合入 merge base 的集成输入。#322 主线数值能力的完整迁移仍待完成。
Changes
HardwareStateLowering.cpp/.h，保留独立物理存储一致性验证；公共 router 拒绝旧源事务，删除旧 transaction-state pass 及两个旧分析 selector。旧 private materializer、Method-summary/shared verifier 仍在库中，属于明确未完成的清理工作，不能声称旧实现全部退出。main-capability-migration.md。Validation
工具链从本 checkout 构建，pyc6 / Clang 22 / LLVM-MLIR 22.1.8。以下严格区分当前提交、较早内容候选和未执行项。
内容限制：功能证据来自
c36a973a加本次任务内容的共享工作区；两处原有修改PythonImportExpressions.inc、transactional-table-data.py逐字节保留且未提交，另有未登记的examples/ppt_pipeline/未提交。因此本地结果不能冒充远程e3355f02的隔离干净 checkout 验收。远程 CI 必须验证实际 head。bash tools/run_examples.sh --tier nightly，15/15，79.36sACIRTransactionalGfsimTests1/1python -m pytest tests/unit/test_example_catalog.py -q，20/20SKIP=pyc-api-hygiene BLACK_NUM_WORKERS=1 pre-commit run --files <file>；mkdocs build --strict；git diff --cached --checkbash tools/run_api_tests.sh --tier gate，26 个 CTest targets 中 18 PASS、8 FAILAPI gate 的 8 个失败 target：
ACIRAnchorArtifactTests、ACIRSourceInterfacePassTests、ACIRRecordProjectionSimplificationTests、ACIRQueueContractsTests、ACIRTransactionEffectsTests、ACIRTableDependencySummaryTests、ACIREnumSourceUnitAuthorityTests、ACIRLitGateTests。混合旧测试需逐项迁移，不能整文件删除或继续缩小成功集合来掩盖失败。此前transactional-constraints的 payload 约束失败已有 owning compiler 修复及聚焦 PASS，但未宣称全部上述 target 已通过。原始日志、JUnit 和独立审查在本地忽略目录
docs/gates/logs/20261101-example-migration/、20261101-example-migration-accepted/、dependency-cache-review/、replay-binary-index-review/等。未上传远程 artifact；本说明提供可远程阅读的结果摘要。更早c36a973a的精简/执行计数仅属于历史候选，不沿用为当前 head PASS。Review checklist
Reviewer notes
review 5702393068 的具体 P1（ordinary typed helper 被唯一 importer 拒绝）已通过 owning importer、authenticated closure、共同 preparation 和跨文件双后端测试修复；要求兼容能力和完整 gate 完成前保持 PR 开放的总体意见仍 OPEN，不声明整个 review 已解决。
本轮源码迁移与 authoring 独立审查由独立 gpt-6-astra 实例执行；compiler、独立测试和实现交叉审查由独立 Codex 实例分工。物理拆分、dependency cache、replay index、名义类型选择、bytecode/parser 保存属性修复及 libdir 修复有有界独立复核；不是最终整个 PR 的 clear。先前曾尝试的有损 SCF text 重解析已撤回，最终 loader 保留显式属性/location。
剩余工作包括旧 private APIs 与混合 native tests 清理、Memory、旧 Queue 同拍容量借用、多时钟、原物理 root/same-Work 导出，以及其他未完成设计。源资产和独立 oracle 保留，known semantics 的实现缺口不宣称为已取消能力。原先提前集中删除旧实现的实施偏差仍记录在能力清单；本轮局部通过不消除该义务。
本次只快进更新现有 PR 的代码和描述，不合并、不关闭 issue、不改变 assignment/project 或评审线程状态。