You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following up on discussion #3948, where @cpholguera suggested updating MASTG-DEMO-0006 before adding a new static demo for MASTG-TEST-0231.
Context
MASTG-TEST-0203 lists the following APIs:
apis: [Log, Logger, System.out.print, System.err.print, java.lang.Throwable#printStackTrace]
MASTG-DEMO-0006 is currently its only demo. From what I can see, MastgTest.kt covers android.util.Log (v, i, w, d, e, wtf) and java.util.logging.Logger.severe, while run.sh hooks android.util.Log!* and java.util.logging.Logger!severe.
The API's that are not covered yet:
System.out.print / println
System.err.print / println
Throwable.printStackTrace
Proposed change:
Add samples for the three APIs above to MastgTest.kt
Extend the hooks to java.io.PrintStream!print* and java.lang.Throwable!printStackTrace* (System.out and System.err are both PrintStream instances)
Regenerate output.txt and logcat_output.txt from a real run
Update the Steps / Observation / Evaluation sections to match
A few scope questions:
Tooling: Should this stay with frida-trace or migrate to frooky + hooks.json? The current demo instructions prefer frooky, and filterEventsByStacktrace looks useful for reducing the noise from hooking java.io.PrintStream.
Demo Conventions: MastgTest.kt has no // SUMMARY: comment and no // FAIL: [MASTG-TEST-0203] annotations. Should I bring it in line with the current demo instructions here, or keep the diff minimal?
Terminology: The demo title currently uses "...Looking for Secrets", while draft PR Fix and narrow terms for better scoping #3592 changes the terminology in this area toward "authenticators". Should this update stay aligned with the current master, or follow the wording from that PR?
I would like to work on this. Happy to be assigned.
Following up on discussion #3948, where @cpholguera suggested updating MASTG-DEMO-0006 before adding a new static demo for MASTG-TEST-0231.
Context
MASTG-TEST-0203 lists the following APIs:
apis: [Log, Logger, System.out.print, System.err.print, java.lang.Throwable#printStackTrace]
MASTG-DEMO-0006 is currently its only demo. From what I can see,
MastgTest.ktcoversandroid.util.Log(v,i,w,d,e,wtf) andjava.util.logging.Logger.severe, whilerun.shhooksandroid.util.Log!*andjava.util.logging.Logger!severe.The API's that are not covered yet:
System.out.print/printlnSystem.err.print/printlnThrowable.printStackTraceProposed change:
MastgTest.ktjava.io.PrintStream!print*andjava.lang.Throwable!printStackTrace*(System.outandSystem.errare bothPrintStreaminstances)output.txtandlogcat_output.txtfrom a real runA few scope questions:
frida-traceor migrate tofrooky+hooks.json? The current demo instructions preferfrooky, andfilterEventsByStacktracelooks useful for reducing the noise from hookingjava.io.PrintStream.MastgTest.kthas no// SUMMARY:comment and no// FAIL: [MASTG-TEST-0203]annotations. Should I bring it in line with the current demo instructions here, or keep the diff minimal?I would like to work on this. Happy to be assigned.