Skip to content

chore(test): pnpm test makes the vendored copies first #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nawid3333 merged 1 commit into from
Nov 9, 2026
Merged

chore(test): pnpm test makes the vendored copies first #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"start:ff": "node tools/launch-ff.mjs",
"start:ff:fresh": "node tools/launch-ff-fresh.mjs",
"start:ff:clean": "web-ext run --source-dir=build_firefox_github --target=firefox-desktop",
"test": "vitest run",
"test": "node tools/sync-vendor.mjs && vitest run",
"test:watch": "vitest",
"test:coverage": "vitest run --coverage",
"test:workflows": "bash tests/workflows/run.sh",
Expand Down
2 changes: 1 addition & 1 deletion tools/sync-vendor.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// so a reviewer can check the base by hash and read the diff in minutes.
//
// The generated files are gitignored. Run after `pnpm install`, or let
// `pnpm run build` do it.
// `pnpm run build` or `pnpm test` do it.

import fs from 'node:fs';
import path from 'node:path';
Expand Down
6 changes: 4 additions & 2 deletions vitest.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ import path from 'node:path';
import {defineConfig} from 'vitest/config';

// Libraries tools/sync-vendor.mjs copies out of node_modules unchanged (patched by pnpm at
// install). The copies are generated, and CI runs the unit tests before it makes them, so a
// test of code that imports one (the save's MP4 writers) gets the npm build itself.
// install). A test of code that imports one (the save's MP4 writers) gets the npm build itself.
// `pnpm test` also makes the copies first: in one local checkout this redirect was not
// called (2026-11-09), and the unit tests there ran on copies from before a dependency
// update (31 failures in hls2mp4 until a build).
const root = import.meta.dirname;
const VENDORED = new Map([
['chrome/player/modules/hls.mjs', 'node_modules/hls.js/dist/hls.mjs'],
Expand Down
Loading