Repository navigation
chore(test): pnpm test makes the vendored copies first - #662
Merged
Merged
Conversation
pnpm run verify runs the unit tests before the build, and only the build ran tools/sync-vendor.mjs. vitest.config.mjs points the vendored imports at the npm builds, but in one local checkout that redirect was not called: right after the dependency updates the unit tests ran on the old hls.mjs and 31 failed (hls2mp4) until a build had refreshed it. sync-vendor takes 0.14 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm testnow runstools/sync-vendor.mjs(0.14 s) beforevitest run.Why:
pnpm run verifyruns the unit tests beforebuild:keep, and only the build refreshed the git-ignored vendored copies (hls.mjs, mp4box, dash.mjs...).vitest.config.mjsis meant to point those imports at the npm builds, but in the main checkout itsresolveIdwas not called at all (probed 2026-11-09). So right after today's dependency updates, the local verify ran the unit tests on the oldhls.mjs, and 31 failed in hls2mp4 until a build refreshed it. CI and fresh worktrees were not affected.Checked: in a fresh worktree with no copies,
pnpm testmade them and then ran 3491 tests, all passing; lint and typecheck clean. The two comments that described the old order are updated.🤖 Generated with Claude Code