Repository navigation
Tests that failed update PRs for no reason of theirs: progress loop, uBlock Origin pin - #651
Merged
Merged
Conversation
…uBlock Origin pin progress-loop.e2e counted the loop's updates in a second of the clock. Some Linux CI runners present only 1 to 5 frames in that second (others 23 to 28, Windows 28), so it failed twice in a row and held back update PRs (#641; #644 lists it 5 times). It now counts the loop's rounds against the frames the video really presented. Both mutations are caught: the screen's every frame gives 70 rounds for 12 frames, a loop that dies 0 or 1. toolchain-updates.test.sh took uBlock Origin's version from main and expected 1.75.0, so the toolchain's own bump went red in Lint workflows (#646). Its fixture now starts at 1.75.0 whatever main pins: 232 checks pass with the pin moved to 1.75.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pause too The rewritten spec counted the loop's rounds only: a loop that stopped telling the client the time passed, and so did one that fell back to the screen's rate after a pause. Mutations, both caught: no updateTime gives 2 times for 12 rounds; the screen's rate after a pause, 57 rounds for 12 frames. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests held back update PRs for reasons that had nothing to do with the update.
progress-loop.e2e: counted updates in one second of the clock. Some Linux runners present only 1 to 5 frames in that second (others 23 to 28, Windows 28), so it failed twice in a row and putholdon Build(deps): Bump pnpm/action-setup from 6.1.0 to 6.1.1 in the actions-minor-and-patch group across 1 directory #641; the weekly report Flaky e2e specs: week to 2026-11-09 #644 lists it 5 times. It now counts the loop's rounds against the frames the video really presented, so a slow runner cannot fail it. Measured on Windows: 12 rounds for 12 frames, twice. Mutations, both caught: the screen's every frame gives 70 rounds for 12 frames; a loop that dies gives 0 or 1 after the pause.toolchain-updates.test.sh: took uBlock Origin's version from main and expected1.75.0, so the toolchain's own bump went red in Lint workflows (Toolchain update: uBlock Origin 1.75.4 #646). Its fixture now starts at1.75.0whatever main pins. 232 checks pass with the pin moved to 1.75.4 (Ubuntu 26.04).Tests only: nothing the extension ships changes.
🤖 Generated with Claude Code