Repository navigation
Toolchain update: uBlock Origin 1.75.4 - #646
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Author
|
@Nawid3333 CI fails on this pull request. It failed twice on this commit, so a flaky test is an unlikely cause.
The last lines of Lint workflowsThe last lines of e2e (Windows, playback 2/3)The last lines of e2e (Linux, playback 1/2)The last lines of e2e (Windows, extension 3/3)The last lines of e2e (Windows, extension 2/3)The last lines of e2e (Windows, playback 1/3)The last lines of e2e (Linux, extension 2/2)The last lines of e2e (Windows, playback 3/3)The new version most likely needs changes to the code here: this pull request is labelled The pull request stays open. A new commit on it runs CI again. https://github.com/Nawid3333/FastStream/actions/runs/42580746682 |
Nawid3333
added a commit
that referenced
this pull request
Nov 9, 2026
…uBlock Origin pin (#651) * Tests that failed update PRs for no reason of theirs: progress loop, uBlock Origin pin progress-loop.e2e counted the loop's updates in a second of the clock. Some Linux CI runners present only 1 to 5 frames in that second (others 23 to 28, Windows 28), so it failed twice in a row and held back update PRs (#641; #644 lists it 5 times). It now counts the loop's rounds against the frames the video really presented. Both mutations are caught: the screen's every frame gives 70 rounds for 12 frames, a loop that dies 0 or 1. toolchain-updates.test.sh took uBlock Origin's version from main and expected 1.75.0, so the toolchain's own bump went red in Lint workflows (#646). Its fixture now starts at 1.75.0 whatever main pins: 232 checks pass with the pin moved to 1.75.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * progress-loop.e2e: each round tells the client the time, and after a pause too The rewritten spec counted the loop's rounds only: a loop that stopped telling the client the time passed, and so did one that fell back to the screen's rate after a pause. Mutations, both caught: no updateTime gives 2 times for 12 rounds; the screen's rate after a pause, 57 rounds for 12 frames. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Superseded by uBlock Origin 1.76.0, which has its own pull request. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uBlock Origin 1.75.0 -> 1.75.4 (newest on AMO at least 3 days old is 1.75.4; tools/setup-dev-profile.mjs pins 1.75.0).
This pull request changes only uBlock Origin's entry in
tools/setup-dev-profile.mjs, and CI has been started on it: the whole ofpnpm run verify, on Linux and on Windows.Routine:
update-prs.ymltells @Nawid3333 once CI has run whether it is ready to merge, and the merge is theirs.Nothing in CI downloads the add-on: this run downloaded https://addons.mozilla.org/firefox/downloads/file/5203014/ublock_origin-1.75.4.xpi and checked it against the SHA-256 AMO gives for it, the check
pnpm run profile:setupmakes too.Nothing here is part of the extension: its build should come out unchanged, and a merge then releases nothing (auto-release.yml compares the builds).
Opened by https://github.com/Nawid3333/FastStream/actions/runs/42577744583