Skip to content

Toolchain update: uBlock Origin 1.75.4 - #646

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
toolchain/ublock-origin-1.75.4
Closed

github-actions[bot] wants to merge 1 commit into
mainfrom
toolchain/ublock-origin-1.75.4

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

uBlock Origin 1.75.0 -> 1.75.4 (newest on AMO at least 3 days old is 1.75.4; tools/setup-dev-profile.mjs pins 1.75.0).

This pull request changes only uBlock Origin's entry in tools/setup-dev-profile.mjs, and CI has been started on it: the whole of pnpm run verify, on Linux and on Windows.

Routine: update-prs.yml tells @Nawid3333 once CI has run whether it is ready to merge, and the merge is theirs.

Nothing in CI downloads the add-on: this run downloaded https://addons.mozilla.org/firefox/downloads/file/5203014/ublock_origin-1.75.4.xpi and checked it against the SHA-256 AMO gives for it, the check pnpm run profile:setup makes too.

Nothing here is part of the extension: its build should come out unchanged, and a merge then releases nothing (auto-release.yml compares the builds).

Opened by https://github.com/Nawid3333/FastStream/actions/runs/42577744583

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file hold Update PRs: not merged while this label is on labels Nov 9, 2026
@github-actions github-actions Bot added the ci-failed CI fails on this update; see the comment label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Author

@Nawid3333 CI fails on this pull request. It failed twice on this commit, so a flaky test is an unlikely cause.

Job Failed step What the step checks
Lint workflows Workflow script tests see its log
e2e (Windows, playback 2/3) End-to-end playback (Windows Firefox) real playback or the installed extension in Firefox; a network stream can also fail on its own
e2e (Linux, playback 1/2) End-to-end playback (Linux Firefox) real playback or the installed extension in Firefox; a network stream can also fail on its own
e2e (Windows, extension 3/3) End-to-end extension tests (Windows Firefox) real playback or the installed extension in Firefox; a network stream can also fail on its own
e2e (Windows, extension 2/3) Install mpv and the native host installing mpv for the MPV specs (.github/mpv-build.json)
e2e (Windows, playback 1/3) Install mpv and the native host installing mpv for the MPV specs (.github/mpv-build.json)
e2e (Linux, extension 2/2) End-to-end extension tests (Linux Firefox) real playback or the installed extension in Firefox; a network stream can also fail on its own
e2e (Windows, playback 3/3) Install mpv and the native host installing mpv for the MPV specs (.github/mpv-build.json)
The last lines of Lint workflows
  ok    no mention
  ok    no link of its own
  ok    the next run reads the real commit
w9 more commits than it lists -> the rest named, with the link
  ok    counts them all
  ok    lists the oldest three
  ok    says how many more
w10 a commit with many files -> eight named, the rest counted
  ok    counts the rest
w11 the issues cannot be read -> the step fails (the failure issue reports it)
  ok    fails
  ok    no issue opened
n1 a failure with none open -> one issue, assigned
  ok    succeeds
  ok    opens it, assigned
n2 a failure with one open -> a comment on it
  ok    comments on #12
  ok    opens none
c1 a clean run -> the failure issue closed
  ok    closes #12
  ok    not the other
== vendored-updates.test.sh
v1 dash.js changed vtt.js -> an issue with the change, older ones closed
  ok    succeeds
  ok    opens "vtt.js changed in dash.js v5.3.0"
  ok    counts the changed lines and links the compare
  ok    closes the older #60, pointing at the new one
  ok    closes #61, whose release the pin has passed
v2 the same vtt.js -> nothing
  ok    succeeds
  ok    opens nothing
v3 vtt.js gone from the new release -> an issue saying so
  ok    succeeds
  ok    says it is gone
v4 raised before -> nothing, nothing fetched
  ok    succeeds
  ok    opens nothing
  ok    fetches nothing
Failed: toolchain-updates.test.sh
##[error]Process completed with exit code 1.
The last lines of e2e (Windows, playback 2/3)
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
  FASTSTREAM_MPV_DEBUG: 1
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-moz-logs-windows-playback-2
  path: logs-moz/
  if-no-files-found: ignore
  retention-days: 7
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 2/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
  FASTSTREAM_MPV_DEBUG: 1
##[endgroup]
No files were found with the provided path: logs-moz/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.56.0.windows.4
Temporarily overriding HOME='D:\a\_temp\d24ed9b9-6e26-4f4e-929b-2fc415430e19' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]"C:\Program Files\Git\bin\git.exe" config --global --add safe.directory D:\a\FastStream\FastStream
Removing SSH command configuration
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :\""
Removing HTTP extra header
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :\""
Removing includeIf entries pointing to credentials config files
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --show-origin --name-only --get-regexp remote.origin.url"
Cleaning up orphan processes
The last lines of e2e (Linux, playback 1/2)
  FIREFOX_BINARY: /opt/hostedtoolcache/firefox/latest/x64/firefox
##[endgroup]
No files were found with the provided path: logs/retried.jsonl. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-logs-Linux-playback-1
  path: logs/
  if-no-files-found: ignore
  retention-days: 30
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 1/2
  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
  PULSE_SERVER: unix:/run/user/1001/pulse/native
  E2E_SOUND_SINK: faststream_e2e
  FIREFOX_BINARY: /opt/hostedtoolcache/firefox/latest/x64/firefox
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]/usr/bin/git version
git version 2.56.0
Temporarily overriding HOME='/home/runner/work/_temp/c46f4b39-bf89-4c6c-b46c-31894067e32b' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/FastStream/FastStream
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes
Terminate orphan process: pid (4488) (pulseaudio)
The last lines of e2e (Windows, extension 3/3)
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
  FASTSTREAM_MPV_DEBUG: 1
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-moz-logs-windows-extension-3
  path: logs-moz/
  if-no-files-found: ignore
  retention-days: 7
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 3/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
  FASTSTREAM_MPV_DEBUG: 1
##[endgroup]
No files were found with the provided path: logs-moz/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.56.0.windows.4
Temporarily overriding HOME='D:\a\_temp\11dca77b-fa06-4824-b5ec-e0b7cdac0d84' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]"C:\Program Files\Git\bin\git.exe" config --global --add safe.directory D:\a\FastStream\FastStream
Removing SSH command configuration
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :\""
Removing HTTP extra header
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :\""
Removing includeIf entries pointing to credentials config files
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --show-origin --name-only --get-regexp remote.origin.url"
Cleaning up orphan processes
The last lines of e2e (Windows, extension 2/3)
env:
  E2E_SHARD: 2/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-moz-logs-windows-extension-2
  path: logs-moz/
  if-no-files-found: ignore
  retention-days: 7
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 2/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
##[endgroup]
No files were found with the provided path: logs-moz/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.56.0.windows.4
Temporarily overriding HOME='D:\a\_temp\615ba47b-d548-46ff-a12b-321f20d7a5b0' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]"C:\Program Files\Git\bin\git.exe" config --global --add safe.directory D:\a\FastStream\FastStream
Removing SSH command configuration
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :\""
Removing HTTP extra header
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :\""
Removing includeIf entries pointing to credentials config files
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --show-origin --name-only --get-regexp remote.origin.url"
Cleaning up orphan processes
The last lines of e2e (Windows, playback 1/3)
env:
  E2E_SHARD: 1/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-moz-logs-windows-playback-1
  path: logs-moz/
  if-no-files-found: ignore
  retention-days: 7
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 1/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
##[endgroup]
No files were found with the provided path: logs-moz/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.56.0.windows.4
Temporarily overriding HOME='D:\a\_temp\a7ecb1ef-c64a-48b9-aa15-b4b8d7775273' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]"C:\Program Files\Git\bin\git.exe" config --global --add safe.directory D:\a\FastStream\FastStream
Removing SSH command configuration
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :\""
Removing HTTP extra header
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :\""
Removing includeIf entries pointing to credentials config files
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --show-origin --name-only --get-regexp remote.origin.url"
Cleaning up orphan processes
The last lines of e2e (Linux, extension 2/2)
  FIREFOX_BINARY: /opt/hostedtoolcache/firefox/latest/x64/firefox
##[endgroup]
No files were found with the provided path: logs/retried.jsonl. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-logs-Linux-extension-2
  path: logs/
  if-no-files-found: ignore
  retention-days: 30
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 2/2
  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
  PULSE_SERVER: unix:/run/user/1001/pulse/native
  E2E_SOUND_SINK: faststream_e2e
  FIREFOX_BINARY: /opt/hostedtoolcache/firefox/latest/x64/firefox
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]/usr/bin/git version
git version 2.56.0
Temporarily overriding HOME='/home/runner/work/_temp/74ce0d77-7527-4617-8182-ccb02882c9c7' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/FastStream/FastStream
Removing SSH command configuration
[command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
Removing HTTP extra header
[command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
Removing includeIf entries pointing to credentials config files
[command]/usr/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
Cleaning up orphan processes
Terminate orphan process: pid (4356) (pulseaudio)
The last lines of e2e (Windows, playback 3/3)
env:
  E2E_SHARD: 3/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
##[endgroup]
No files were found with the provided path: logs/. No artifacts will be uploaded.
##[group]Run actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9
with:
  name: e2e-moz-logs-windows-playback-3
  path: logs-moz/
  if-no-files-found: ignore
  retention-days: 7
  compression-level: 6
  overwrite: false
  include-hidden-files: false
  archive: true
env:
  E2E_SHARD: 3/3
  PNPM_HOME: C:\Users\runneradmin\setup-pnpm\node_modules\.bin
  FIREFOX_BINARY: C:\Program Files\Firefox_latest\firefox.exe
##[endgroup]
No files were found with the provided path: logs-moz/. No artifacts will be uploaded.
Post job cleanup.
Pruning is unnecessary.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.56.0.windows.4
Temporarily overriding HOME='D:\a\_temp\19083d76-27fd-41ff-bc2b-71635c2616eb' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]"C:\Program Files\Git\bin\git.exe" config --global --add safe.directory D:\a\FastStream\FastStream
Removing SSH command configuration
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :\""
Removing HTTP extra header
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :\""
Removing includeIf entries pointing to credentials config files
[command]"C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp ^includeIf\.gitdir:
[command]"C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "git config --local --show-origin --name-only --get-regexp remote.origin.url"
Cleaning up orphan processes

The new version most likely needs changes to the code here: this pull request is labelled hold, and #649 says what to do.

The pull request stays open. A new commit on it runs CI again.
Closing this pull request skips this version for good; toolchain-updates.yml raises the next one.

https://github.com/Nawid3333/FastStream/actions/runs/42580746682

Nawid3333 added a commit that referenced this pull request Nov 9, 2026
…uBlock Origin pin (#651)

* Tests that failed update PRs for no reason of theirs: progress loop, uBlock Origin pin

progress-loop.e2e counted the loop's updates in a second of the clock. Some Linux CI runners
present only 1 to 5 frames in that second (others 23 to 28, Windows 28), so it failed twice in a
row and held back update PRs (#641; #644 lists it 5 times). It now counts the loop's rounds
against the frames the video really presented. Both mutations are caught: the screen's every
frame gives 70 rounds for 12 frames, a loop that dies 0 or 1.

toolchain-updates.test.sh took uBlock Origin's version from main and expected 1.75.0, so the
toolchain's own bump went red in Lint workflows (#646). Its fixture now starts at 1.75.0
whatever main pins: 232 checks pass with the pin moved to 1.75.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* progress-loop.e2e: each round tells the client the time, and after a pause too

The rewritten spec counted the loop's rounds only: a loop that stopped telling the client the
time passed, and so did one that fell back to the screen's rate after a pause. Mutations, both
caught: no updateTime gives 2 times for 12 rounds; the screen's rate after a pause, 57 rounds for
12 frames.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Author

Superseded by uBlock Origin 1.76.0, which has its own pull request.

@github-actions github-actions Bot closed this Nov 9, 2026
@github-actions
github-actions Bot deleted the toolchain/ublock-origin-1.75.4 branch November 9, 2026 15:00
@github-actions github-actions Bot mentioned this pull request Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-failed CI fails on this update; see the comment dependencies Pull requests that update a dependency file hold Update PRs: not merged while this label is on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant