Skip to content

refactor(tui): adopt Ink window sizing and terminal suspension APIs - #1872

Draft
DenizOkcu wants to merge 6 commits into
Nano-Collective:mainfrom
DenizOkcu:review/ink-v8-terminal-apis
Draft

DenizOkcu wants to merge 6 commits into
Nano-Collective:mainfrom
DenizOkcu:review/ink-v8-terminal-apis

Conversation

@DenizOkcu

Copy link
Copy Markdown
Contributor

Why

Split from #1570 following @addyCooks’ request for smaller PRs. This isolates scope (c); depends on #1871 (which depends on #1869).

Changes

  • Replace the storage inspector's manual resize hook with useWindowSize().
  • Use suspendTerminal() around the wizard's external-editor handoff.
  • Restore terminal modes when the renderer's exit promise rejects as well as resolves.

Review / merge order

Draft until the input PR merges. Fork-only branches cannot be upstream PR bases, so Files changed currently includes dependencies. Use the scoped comparison. After dependencies merge, rebase onto upstream main, rerun checks, and mark ready.

Validation

Committed lockfile YAML and whitespace checks pass. This branch still needs its own CI. Real-terminal editor handoff: not run; manual procedures are in docs/features/terminal-compatibility.md. Parser/rendering tests are not a substitute for that smoke test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentation area:tui Terminal UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant