Repository navigation
Conversation
…VF-PQ training build_hierarchical, build_fine_clusters and IVF-PQ train_per_cluster used managed memory for small arrays that are read or written on the host (mesocluster labels and sizes, per-mesocluster row ids, cluster sizes and offsets). Allocate them from the workspace resource and copy them to or from host vectors explicitly, with a stream sync before the host reads them. This removes the managed allocations and the CPU/GPU page migrations they cause on every balanced k-means fit and IVF-PQ build.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test caab490 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workstream B4 (#2783). Candidate fix C2: balanced k-means (build_hierarchical/build_fine_clusters) and IVF-PQ train_per_cluster use device memory plus explicit host copies instead of managed memory. Same CI config as #2816/#2817, with 2x H100 12.9.2. Do not merge.