Skip to content

fix: The constructor checks useDynamicTree but doesn’t validate dynamicTreeMaxTopK if set #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
A-transformer wants to merge 1 commit into from
Closed

fix: The constructor checks useDynamicTree but doesn’t validate dynamicTreeMaxTopK if set #2977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/tensorrt_llm/executor/decodingConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ EagleConfig::EagleConfig(std::optional<EagleChoices> eagleChoices, bool greedySa
TLLM_CHECK_WITH_INFO(eagleChoices.has_value() == false,
"When dynamic tree is enabled (for Eagle-2), eagle choices should not be set.");
}
if (mDynamicTreeMaxTopK.has_value())
{
TLLM_CHECK_WITH_INFO(mDynamicTreeMaxTopK.value() > 0, "dynamicTreeMaxTopK must be positive");
}
}

bool EagleConfig::operator==(EagleConfig const& other) const
Expand Down