Repository navigation
fix: The constructor checks useDynamicTree but doesn’t validate dynamicTreeMaxTopK if set - #2977
Closed
A-transformer wants to merge 1 commit into
Closed
A-transformer wants to merge 1 commit into
A-transformer wants to merge 1 commit into
Conversation
A-transformer
force-pushed
the
mdynamictreemaxtopk_check
branch
from
March 21, 2025 17:51
efe7290 to
f81850b
Compare
Member
|
/bot run |
Collaborator
|
PR_Github #212 [ run ] triggered by Bot |
Collaborator
|
PR_Github #212 [ run ] completed with state |
Collaborator
juney-nvidia
changed the title
Collaborator
|
/bot run |
Collaborator
|
PR_Github #242 [ run ] triggered by Bot |
Collaborator
|
PR_Github #242 [ run ] completed with state |
The check is tied to mDynamicTreeMaxTopK, which is only meaningful in the context of useDynamicTree. While the check could theoretically apply even when useDynamicTree is false, enforcing it here ensures it’s validated at construction time alongside related conditions. Signed-off-by: root <root@us1.us-central1-f.c.pivotal-being-453505-m1.internal>
kaiyux
force-pushed
the
mdynamictreemaxtopk_check
branch
from
March 24, 2025 09:07
6112098 to
e60f05d
Compare
Member
|
@A-transformer The DCO check failed with the error message Can you help fix it? |
Contributor
|
Closing as no activities from requester for +10 days. Feel free to reopen 👍 |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check is tied to mDynamicTreeMaxTopK, which is only meaningful in the context of useDynamicTree. While the check could theoretically apply even when useDynamicTree is false, enforcing it here ensures it’s validated at construction time alongside related conditions.