Repository navigation
Conversation
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "Test waive" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
No actionable comments were generated in the recent review. WalkthroughThe integration test waiver list adds a ChangesApertus test waiver
Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Possibly related PRs
Suggested reviewers: Merge Risk:
|
|
PR_Github #83259 [ skip ] triggered by Bot. Commit: |
sunnyqgg
left a comment
There was a problem hiding this comment.
I checked the waive against the test-db lists, the waive parser and the failing A10 run. The line itself is correct: it matches the exact failing node id, A10 is the only L0 platform that runs this test (l0_a10.yml:35), and the other 12 Apertus cases pass in that run. Counts: 0 blocker, 0 possibly blocking, 1 required, 0 nice-to-have. The required item is inline: the root cause is a two-line bug in the test, and that fix should land instead of this waive or right after it.
|
PR_Github #83259 [ skip ] completed with state |
Description
Temporarily waive 1 failed case(s) on
A10. Opened automatically by auto-waive (draft; a human reviews and merges).The native main-break detector (
native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1) reportsunittest/_torch/modeling/test_modeling_apertus.py::TestApertus::test_apertus_allclose_to_hf[backend:trtllm-use_cuda_graph:True]broken on main for A10: failure signatureattributeerror: tuple object has no attribute batch_size, onset 2026-11-07T00:06:28Z, latest failure 2026-11-07T01:06:18Z. Policynative_p3@1.0.0selected it; https://nvbugs/7060043 tracks the fix. ScopeA10is the stage prefix that ran the failing test.Tests in this break event:
unittest/_torch/modeling/test_modeling_apertus.py::TestApertus::test_apertus_allclose_to_hf[backend:trtllm-use_cuda_graph:True]on A10PRs whose pre-merge runs hit this break (rebase or re-run after this merges):
What to check before merging:
A10matches the failing stage and no narrower waiver already exists.Provenance
native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1, policynative_p3@1.0.08a83e72e-bfe4-488d-9ae8-95e1349667d9; snapshot SHA-2567f4ea50cb134560abef028c66eef60707654332a7bba7a5d9a277050915a9ae4; config SHA-25680248ef10d45ba9db91b7f0a8258df726f95897e1dc5b17a275cf58bc305d1f5unittest/_torch/modeling/test_modeling_apertus.py::TestApertus::test_apertus_allclose_to_hf[backend:trtllm-use_cuda_graph:True]: incident7bce537e1d58910b886cf1c1e494cbed9edac3cf03e7ade6cb5b8a636a51c770, observation25c49228ab43a10e4c8cda98772ea61080fc65c72e19d750c17f648b7097d2caTest Coverage
Review the incident evidence and selector scope before merging. This proposal does not
establish that main is fixed. Confirm restoration separately after the corrective change.
PR Checklist
Dev Engineer Review
The change adds one A10-only waiver for the Apertus TRT-LLM test with CUDA graphs enabled. It links the waiver to NVBUG 7060043. The change does not establish that the underlying failure is fixed; restore the test after the fix and a passing A10 run.
QA Engineer Review
Modified
tests/integration/test_lists/waives.txt. The entry skipsTestApertus::test_apertus_allclose_to_hf[backend:trtllm-use_cuda_graph:True]on A10 only. The waiver narrows the impact to that test selector and hardware. Coverage verdict: needs follow-up until the bug is fixed and the test passes.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds an A10 waiver for one Apertus selector. No test functions changed; the waived test is excluded from the applicable run while the entry remains.