Repository navigation
Write validation: regex constants to shared/domain, one function per composite write - #290
Merged
Merged
Conversation
mschwoer
force-pushed
the
refactor_validation_III
branch
from
November 12, 2026 20:57
8549660 to
b5b6818
Compare
mschwoer
force-pushed
the
refactor_validation_I
branch
from
November 12, 2026 20:57
b2f1b85 to
5869aa6
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Write validation: toast_result in the webapp, drop the webapp read filter check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #289.
No change of validation behaviour.
_mongo/models.pyand the webapp toshared/domainproject_settings.update_to_latest: assigns the latest version first, then removes the old assignment, so a failure loses nothingsettings.create(..., archive_previous=)check_not_assigned_with_same_filtersis privaterefactor_validation_IIpoints at the same commit and has no PR.🤖 Generated with Claude Code