Skip to content

Write validation: regex constants to shared/domain, one function per composite write - #290

Merged
mschwoer merged 5 commits into
refactor_validation_Ifrom
refactor_validation_III
Nov 19, 2026
Merged

mschwoer merged 5 commits into
refactor_validation_Ifrom
refactor_validation_III

Conversation

@mschwoer

Copy link
Copy Markdown
Contributor

Stacked on #289.

No change of validation behaviour.

  • Regex constants and project id bounds move from _mongo/models.py and the webapp to shared/domain
  • project_settings.update_to_latest: assigns the latest version first, then removes the old assignment, so a failure loses nothing
  • settings.create(..., archive_previous=)
  • check_not_assigned_with_same_filters is private

refactor_validation_II points at the same commit and has no PR.

🤖 Generated with Claude Code

@mschwoer
mschwoer force-pushed the refactor_validation_III branch from 8549660 to b5b6818 Compare November 12, 2026 20:57
@mschwoer
mschwoer force-pushed the refactor_validation_I branch from b2f1b85 to 5869aa6 Compare November 12, 2026 20:57
@claude

claude Bot commented Nov 12, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Write validation: toast_result in the webapp, drop the webapp read filter check
@mschwoer
mschwoer merged commit a722e82 into refactor_validation_I Nov 19, 2026
@mschwoer
mschwoer deleted the refactor_validation_III branch November 19, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant