Repository navigation
Write validation: design and implementation plan - #289
Merged
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
--- # Conversation that produced these changes --- ## User prompt "Now create an implementation plan. Refactorings upfront, then several human-reviewable slices." ## Clarifying round 1 Q: Decision 4.4 of VALIDATION_DESIGN.md: where do the validation rules for writes live? This determines the shape of every slice. - shared.db API modules (Recommended) <-- chosen - New shared/services Q: Decision 4.1: how do clients see validation errors from the pydantic input types? - One domain error (Recommended) <-- chosen - Two error types Q: Decision 4.3: does the plan include write tools for the MCP server? Today the webapp is the only writing client. - No, leave out (Recommended) - Yes, final slice <-- chosen Q: Decision 4.5: forms and Mongo models have different max lengths (settings file names and software 64 vs 128, project description 256 vs 512, messenger id 64 vs 512). Which value becomes the single declared limit? - The form's (Recommended) <-- chosen - The model's Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
mschwoer
force-pushed
the
refactor_validation_I
branch
from
November 12, 2026 20:57
b2f1b85 to
5869aa6
Compare
Write validation: toast_result in the webapp, drop the webapp read filter check
Write validation: regex constants to shared/domain, one function per composite write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #316.
Based on
refactor_db_XIX.design_docs/VALIDATION_DESIGN.mdchecked against the code after the DB refactoringdesign_docs/VALIDATION_PLAN.md: refactorings, then one slice per aggregate🤖 Generated with Claude Code