Skip to content

Write validation: design and implementation plan - #289

Merged
mschwoer merged 8 commits into
refactor_db_XIXfrom
refactor_validation_I
Nov 19, 2026
Merged

mschwoer merged 8 commits into
refactor_db_XIXfrom
refactor_validation_I

Conversation

@mschwoer

@mschwoer mschwoer commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #316.

Based on refactor_db_XIX.

  • design_docs/VALIDATION_DESIGN.md checked against the code after the DB refactoring
  • design_docs/VALIDATION_PLAN.md: refactorings, then one slice per aggregate

🤖 Generated with Claude Code

@claude

claude Bot commented Nov 12, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

mschwoer and others added 6 commits November 12, 2026 21:56
---
# Conversation that produced these changes
---

## User prompt

"Now create an implementation plan. Refactorings upfront, then several human-reviewable slices."

## Clarifying round 1

Q: Decision 4.4 of VALIDATION_DESIGN.md: where do the validation rules for writes live? This determines the shape of every slice.
  - shared.db API modules (Recommended)  <-- chosen
  - New shared/services

Q: Decision 4.1: how do clients see validation errors from the pydantic input types?
  - One domain error (Recommended)  <-- chosen
  - Two error types

Q: Decision 4.3: does the plan include write tools for the MCP server? Today the webapp is the only writing client.
  - No, leave out (Recommended)
  - Yes, final slice  <-- chosen

Q: Decision 4.5: forms and Mongo models have different max lengths (settings file names and software 64 vs 128, project description 256 vs 512, messenger id 64 vs 512). Which value becomes the single declared limit?
  - The form's (Recommended)  <-- chosen
  - The model's

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@mschwoer
mschwoer force-pushed the refactor_validation_I branch from b2f1b85 to 5869aa6 Compare November 12, 2026 20:57
Write validation: toast_result in the webapp, drop the webapp read filter check
Write validation: regex constants to shared/domain, one function per composite write
@mschwoer
mschwoer merged commit 8b6fedd into refactor_db_XIX Nov 19, 2026
@mschwoer
mschwoer deleted the refactor_validation_I branch November 19, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant