Repository navigation
docs(protocols): second pass over the IPv6 extension headers (#1103) - #1783
Merged
Merged
Conversation
Reads the MH, HOPOPT, IPv6-Opts, IPv6-Route and ESP prose phase 1 left unread, with their schemas, data models and pages. - Data models: versionchanged on the 31 classes that gained a required field since 1.4.1.post2, each citing the issue the field came from. - HOPOPT/IPv6-Opts, IPv6-Route and MH class directives gain the missing #1235 reserved-bit, IP_DFF length and #1223 padding rows; MH's also cites #1329 for its reserved fields and flag bits. - MH dispatch note: Schema subclasses each have their own ABC cache (#439). - Drop four stale TODOs: every MH type, option and CGA extension has a handler. MH and ESP modules are not "MH/ESP only"; esp.rst drops an unchecked "unlike every other protocol"; MH's table names mh.reserved. - Field comments: lengths are octets, an option length includes its header, Type 2 holds one address; fix typos (router alter, cation, Retune, ANSI.1, LAA), two mislabelled data models, a from_dict link. AST guard: 16 .py files identical; tests/project and related tests pass. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
Reads the MH, HOPOPT, IPv6-Opts, IPv6-Route and ESP prose phase 1 left
unread, with their schemas, data models and pages.
field since 1.4.1.post2, each citing the issue the field came from.
fix(ipv6): reserved bits not named in a BitField are written back as zero (Frag, RPL routing, MPL, IP_DFF, Quick-Start) #1235 reserved-bit, IP_DFF length and fix(corekit): non-zero padding octets are zeroed on rebuild #1223 padding rows; MH's also
cites fix(mh): reserved fields, BU/BA flag bits and PadN contents are written back as zero #1329 for its reserved fields and flag bits.
handler. MH and ESP modules are not "MH/ESP only"; esp.rst drops an
unchecked "unlike every other protocol"; MH's table names mh.reserved.
header, Type 2 holds one address; fix typos (router alter, cation,
Retune, ANSI.1, LAA), two mislabelled data models, a from_dict link.
AST guard: 16 .py files identical; tests/project and related tests pass.
Refs #1103