Skip to content

docs(protocols): second pass over the IPv6 extension headers (#1103) - #1783

Merged
JarryShaw merged 2 commits into
mainfrom
docs/1103-internet-b
Oct 15, 2026
Merged

JarryShaw merged 2 commits into
mainfrom
docs/1103-internet-b

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Summary

#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.

Reads the MH, HOPOPT, IPv6-Opts, IPv6-Route and ESP prose phase 1 left
unread, with their schemas, data models and pages.

AST guard: 16 .py files identical; tests/project and related tests pass.

Refs #1103

Reads the MH, HOPOPT, IPv6-Opts, IPv6-Route and ESP prose phase 1 left
unread, with their schemas, data models and pages.

- Data models: versionchanged on the 31 classes that gained a required
  field since 1.4.1.post2, each citing the issue the field came from.
- HOPOPT/IPv6-Opts, IPv6-Route and MH class directives gain the missing
  #1235 reserved-bit, IP_DFF length and #1223 padding rows; MH's also
  cites #1329 for its reserved fields and flag bits.
- MH dispatch note: Schema subclasses each have their own ABC cache (#439).
- Drop four stale TODOs: every MH type, option and CGA extension has a
  handler. MH and ESP modules are not "MH/ESP only"; esp.rst drops an
  unchecked "unlike every other protocol"; MH's table names mh.reserved.
- Field comments: lengths are octets, an option length includes its
  header, Type 2 holds one address; fix typos (router alter, cation,
  Retune, ANSI.1, LAA), two mislabelled data models, a from_dict link.

AST guard: 16 .py files identical; tests/project and related tests pass.

Refs #1103
@JarryShaw JarryShaw added the docs Pull requests that change documentation only (docs: subject prefix) label Oct 15, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at ff98e9505. Sonnet review and re-check (author: Opus). The first review blocked: four mh.py directives cited #1324 for fields that came with #1329. The fix round corrected the citations against #1345. The AST guard is identical against the base, tests/project passes, and every added directive says 1.5.0.

@JarryShaw JarryShaw added the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw
JarryShaw merged commit ccd169e into main Oct 15, 2026
6 of 7 checks passed
@JarryShaw
JarryShaw deleted the docs/1103-internet-b branch October 15, 2026 18:54
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw JarryShaw moved this to Done in PyPCAPKit Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant