Skip to content

fix(mh): reserved fields, BU/BA flag bits and PadN contents are written back as zero #1329

Closed

Description

@JarryShaw

Describe the bug
Header reserved is PaddingField(length=1) (schema/internet/mh.py:565); the BA flags namespace names only K (schema/internet/mh.py:2636-2640); see #1288 and #1223.

To Reproduce
from_data round trip:

  • header reserved 3b0000aa00000000 -> 3b00000000000000
  • BRR reserved 3b0000000000aabb -> 3b00000000000000
  • BU flags ffff -> f000; BA flags ff -> 80
  • PadN contents 0106aabbccddeeff -> 0106000000000000

Expected behavior
Reserved bits and padding come back as parsed.

Found by the internet-v4 round-trip audit (#1202); reproduced on main at 11ae68ebf (repro check D16).

Found by the internet-v4 round-trip audit (#1202). The repro was re-checked by an independent verifier, and I re-ran it on main at 11ae68ebf.

Activity

  1. added
    fixPull requests that fix a defect (fix: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 7, 2026
  2. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    OwnerAuthor

    Partly fixed by #1345, which will say Refs #1329. It covers the header, BRR, Handoff Indicator, IPv4 Home Address and ANI reserved fields and the BU/BA flag bits. The remaining half — PadN contents (0106aabbccddeeff → 0106000000000000) — is a PaddingField site and rides on #1223. Close this once both have merged.

  3. JarryShaw commented on Oct 7, 2026

    @JarryShaw
    OwnerAuthor

    #1345 has merged and covers the header, BRR, Handoff Indicator, IPv4 Home Address and ANI reserved fields and the BU/BA flag bits. What is left is the PadN contents (0106aabbccddeeff → 0106000000000000), which is a PaddingField site. Blocked until #1223's PaddingField fix lands.

  4. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 7, 2026
  5. JarryShaw commented on Oct 8, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked alongside #1223: its PadN remainder is in scope for the #1223 worker (fix/1223-padding-kept-as-captured), which owns schema/internet/mh.py.

  6. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 8, 2026
  7. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions