Skip to content

Encrypted 'download all' ZIP opens new download sessions after 15 minutes #31

Closed

Description

@Hiczownik

Where: src/fileholder-ui/src/features/download/hooks/useFileDownload.ts:234

The browser-built ZIP asks for each file's download URL only when its turn comes. Once the 15-minute download session expires, downloadSessionStore.get(token) returns null and openSession runs again for the next file. That counts another download, or gets a 410.

Example: a 1-download bundle with 5 encrypted files of 1 GB each on a slow connection. The first session marks the bundle deleted, the next file gets a 410, and the ZIP fails partway, so the bundle can never be downloaded again. With max 10 downloads, a 2-hour ZIP silently uses about 8 of them.

Suggested fix: get all file URLs when the session opens, or let the client renew URLs within the existing session without counting another download.

Found during a code review of the whole src tree.

Activity

  1. added
    bugSomething isn't working
    frontendBrowser / React app
    backend.NET API and services
    downloadDownloading and saving files
    P1Priority 1: data/download loss or security hole
    on Oct 20, 2026
  2. added a commit that references this issue on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Priority 1: data/download loss or security holebackend.NET API and servicesbugSomething isn't workingdownloadDownloading and saving filesfrontendBrowser / React app

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions