Repository navigation
[access] refactor(example-set): remover, Talk store, record and people take value objects instead of loose parameters - #7601
Conversation
…ey and entry together Assisted-by: ClaudeCode:claude-opus-5-5
…call Assisted-by: ClaudeCode:claude-opus-5-5
…ey and what follow() made Assisted-by: ClaudeCode:claude-opus-5-5
…builds Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…terms Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite is red, but not because of this PR.
No fix for the development failure exists yet. Per the lane rules this PR is finished as opened, so I'm not pushing to it. It will need a re-run once development is green. Generated by Claude Code |
|
Further quality-lane failures here (PHP phpcs/phpstan/psalm/phpmd, Hydra gates) flag files outside this diff on the sibling PRs, so I won't comment on each one. Per the lane rules this PR is finished as opened, so I'm not pushing to it. Generated by Claude Code |
|
Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 19:16 UTC
Download the full PDF report from the workflow artifacts.
SIG unit interfacing (lane K30): example-set methods with more than 4 parameters, part 2.
What changed
ExampleSetRemover::deleteObject/deleteFiles(5 each) take anExampleSetRecordedObject(record key and entry) instead of the key, entry and derived object id.ExampleSetTalkStore::heldCall(5) takes the declared call (start,end) and builds the twoDateTimes itself, exactly as the caller did.ExampleSetRecord::hold(6) takes anExampleSetFollowedEntry(part, key, what follow() made); the report half moved to a 2-parameter helper. The report it returns and the record it writes are unchanged.ExampleSetPeople::install(5) takes theExampleSetAccountTermsits caller builds (set id, adoptable ids, password) instead of building them from three parameters.ExampleSetTestCase, Talk conversations golden, people accounts golden, profiles test) follow the new call shapes with unchanged expectations and fixtures.Numbers (lane_measure, K30 scope): gt4 470 → 409 (this PR alone), gt6 unchanged.
What ran (on the branch, which is current
origin/developmentplus these commits):vendor/bin/phpunit -c phpunit.xml --no-coverage tests/Unit/Architecture tests/Unit/Contract tests/Unit/Kernel tests/Unit/Service/Rules tests/Unit/Controller/ControllerServicesWiringTest.php tests/Unit/Controller/ControllerSessionWiringTest.php tests/Unit/Service/ExampleSet tests/Unit/Service/ConfigurationDeployment tests/Unit/Service/Vocabulary tests/Unit/Command— green;php -l,phpcs(no new errors or warnings) andphpstan(no errors) on every touched production file. All five K30 branches merge into development without conflicts.AI disclosure: written by Claude Code (Opus) as cloud lane K30 of round 10c (SIG unit interfacing, P1); reviewed by its own guards only.
Generated by Claude Code