Skip to content

[access] refactor(example-set): remover, Talk store, record and people take value objects instead of loose parameters - #7601

Merged
rubenvdlinde merged 7 commits into
mainfrom
cloud/k30-example-set-record
Nov 9, 2026
Merged

rubenvdlinde merged 7 commits into
mainfrom
cloud/k30-example-set-record

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

SIG unit interfacing (lane K30): example-set methods with more than 4 parameters, part 2.

What changed

  • ExampleSetRemover::deleteObject / deleteFiles (5 each) take an ExampleSetRecordedObject (record key and entry) instead of the key, entry and derived object id.
  • ExampleSetTalkStore::heldCall (5) takes the declared call (start, end) and builds the two DateTimes itself, exactly as the caller did.
  • ExampleSetRecord::hold (6) takes an ExampleSetFollowedEntry (part, key, what follow() made); the report half moved to a 2-parameter helper. The report it returns and the record it writes are unchanged.
  • ExampleSetPeople::install (5) takes the ExampleSetAccountTerms its caller builds (set id, adoptable ids, password) instead of building them from three parameters.
  • Test doubles and goldens (ExampleSetTestCase, Talk conversations golden, people accounts golden, profiles test) follow the new call shapes with unchanged expectations and fixtures.

Numbers (lane_measure, K30 scope): gt4 470 → 409 (this PR alone), gt6 unchanged.

What ran (on the branch, which is current origin/development plus these commits): vendor/bin/phpunit -c phpunit.xml --no-coverage tests/Unit/Architecture tests/Unit/Contract tests/Unit/Kernel tests/Unit/Service/Rules tests/Unit/Controller/ControllerServicesWiringTest.php tests/Unit/Controller/ControllerSessionWiringTest.php tests/Unit/Service/ExampleSet tests/Unit/Service/ConfigurationDeployment tests/Unit/Service/Vocabulary tests/Unit/Command — green; php -l, phpcs (no new errors or warnings) and phpstan (no errors) on every touched production file. All five K30 branches merge into development without conflicts.

AI disclosure: written by Claude Code (Opus) as cloud lane K30 of round 10c (SIG unit interfacing, P1); reviewed by its own guards only.


Generated by Claude Code

…ey and entry together

Assisted-by: ClaudeCode:claude-opus-5-5
…call

Assisted-by: ClaudeCode:claude-opus-5-5
…ey and what follow() made

Assisted-by: ClaudeCode:claude-opus-5-5
…builds

Assisted-by: ClaudeCode:claude-opus-5-5
…terms

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde changed the base branch from development to main November 9, 2026 06:52

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red, but not because of this PR.

No fix for the development failure exists yet. Per the lane rules this PR is finished as opened, so I'm not pushing to it. It will need a re-run once development is green.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Frontend Check (test:l10n:parity), Frontend Check (format) and Vue Quality (eslint) are red, but not because of this PR. This PR changes no src/, Vue or l10n/ files; it is PHP under lib/Service/ExampleSet plus tests. These checks fail identically on #7596–#7599 on the same development base. CLAUDE.md records the l10n gates as red at HEAD, and the eslint errors are in development's Vue files.

Further quality-lane failures here (PHP phpcs/phpstan/psalm/phpmd, Hydra gates) flag files outside this diff on the sibling PRs, so I won't comment on each one. Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (psalm) is red, but not because of this PR. Psalm on this PR's touched files finds one error: UnusedClosureParam at lib/Service/ExampleSet/ExampleSetRemover.php:406, the 'label' => static fn (string $name, array $entry) closure. This PR does not change that line, and psalm reports the same error at the same line on origin/development. Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 5f8aa50 into main Nov 9, 2026
37 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 166bb4a

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 19:16 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants