Skip to content

refactor(configuration): ConfigurationSnapshot takes its address and provenance as value objects - #7596

Merged
rubenvdlinde merged 3 commits into
mainfrom
cloud/k30-config-snapshot
Nov 9, 2026
Merged

rubenvdlinde merged 3 commits into
mainfrom
cloud/k30-config-snapshot

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

SIG unit interfacing (lane K30): ConfigurationSnapshot::__construct took 7 parameters.

What changed

  • ConfigurationSnapshot now takes ConfigurationAddress $address (the existing layer / layer ref / key value object), $value, $present and an optional new ConfigurationProvenance (deployment uuid, updated by). Its public readonly properties (layer, layerRef, configKey, value, present, deploymentUuid, updatedBy) and jsonSerialize() output are unchanged, so every reader is untouched.
  • ConfigurationValueStore builds the snapshot from the address and row provenance; absent() builds the address.
  • Tests that build snapshots follow the new constructor; no assertion changed.

Numbers (lane_measure, K30 scope): gt4 470 → 460, gt6 126 → 116 (this PR alone).

What ran (on the branch, which is current origin/development plus these commits): vendor/bin/phpunit -c phpunit.xml --no-coverage tests/Unit/Architecture tests/Unit/Contract tests/Unit/Kernel tests/Unit/Service/Rules tests/Unit/Controller/ControllerServicesWiringTest.php tests/Unit/Controller/ControllerSessionWiringTest.php tests/Unit/Service/ExampleSet tests/Unit/Service/ConfigurationDeployment tests/Unit/Service/Vocabulary tests/Unit/Command — green; php -l, phpcs (no new errors or warnings) and phpstan (no errors) on every touched production file. All five K30 branches merge into development without conflicts.

AI disclosure: written by Claude Code (Opus) as cloud lane K30 of round 10c (SIG unit interfacing, P1); reviewed by its own guards only.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red, but not because of this PR.

No fix for the development failure exists yet. Per the lane rules this PR is finished as opened, so I'm not pushing to it. It will need a re-run once development is green.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Frontend Check (test:l10n) is red, but not because of this PR. This PR changes only PHP files under lib/Service/ConfigurationDeployment and their tests, with nothing in src/ or l10n/. The repo's CLAUDE.md already records test:l10n as red at development HEAD. The same holds for any other frontend check (eslint, format, unit, l10n parity) that goes red in this run: those failures come from the development base. #7597 shows the same set. Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpcs) is red, but not because of this PR. It flags the same 8 files outside this diff as on #7597: lib/Db/ImportPreviewRow.php, lib/Db/RuleRun.php, lib/Db/CaseItem.php, lib/Db/EntityRelation.php, lib/Db/MagicMapper/MagicObjectSearchInterface.php, lib/Service/Flow/FlowTokenRouter.php, lib/Service/Object/SaveObject/RelationCascadeHandler.php and lib/Service/ContractBindings.php. The files this PR changes give no phpcs errors locally. Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpstan) is red, but not because of this PR. None of the 12 files with phpstan errors is in this diff; they include BackgroundJob/FileTextExtractionJob.php, Controller/EndpointsController.php, Controller/TaskNotesController.php and Controller/WebhooksController.php. phpstan on this PR's touched files (ConfigurationSnapshot, ConfigurationProvenance, ConfigurationValueStore) reports no errors locally. Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Hydra Gates is red, but not because of this PR. The same 7 gates fail with the same counts as on #7597, whose only change is a one-method signature in ConceptRepository:

  • 3: 1 stub finding
  • 7: 113 no-admin-idor controller methods
  • 12: 1 NcSelect label
  • 17: 1 redundant controller
  • 40: 1 form label
  • 46: 2 unresolved spec anchors
  • 49: 19 controller methods

This PR changes no controller or Vue file. The @spec anchor it adds on ConfigurationProvenance is the same one ConfigurationAddress and ConfigurationSnapshot already use, and gate 46's count is unchanged (2 on both PRs). Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpmd) is red, but not because of this PR. It flags none of the files this PR changes (ConfigurationSnapshot, ConfigurationProvenance, ConfigurationValueStore). The findings are in existing files, among them DeploymentService.php:112/158, ExampleSetFlows.php, ExampleSetRemover.php:383, ExampleSetTaskDates.php and ExampleSetValues.php, and the same set appears on #7599. Per the lane rules this PR is finished as opened, so I'm not pushing to it.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 74a843c into main Nov 9, 2026
37 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ a44d62c

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 49041/49051 · 19 skipped
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 18:17 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants