Repository navigation
refactor(configuration): ConfigurationSnapshot takes its address and provenance as value objects - #7596
Conversation
…ovenance as value objects Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite is red, but not because of this PR.
No fix for the development failure exists yet. Per the lane rules this PR is finished as opened, so I'm not pushing to it. It will need a re-run once development is green. Generated by Claude Code |
|
Generated by Claude Code |
|
Generated by Claude Code |
|
Generated by Claude Code |
|
This PR changes no controller or Vue file. The Generated by Claude Code |
|
Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49041/49051 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 18:17 UTC
Download the full PDF report from the workflow artifacts.
SIG unit interfacing (lane K30):
ConfigurationSnapshot::__constructtook 7 parameters.What changed
ConfigurationSnapshotnow takesConfigurationAddress $address(the existing layer / layer ref / key value object),$value,$presentand an optional newConfigurationProvenance(deployment uuid, updated by). Its public readonly properties (layer,layerRef,configKey,value,present,deploymentUuid,updatedBy) andjsonSerialize()output are unchanged, so every reader is untouched.ConfigurationValueStorebuilds the snapshot from the address and row provenance;absent()builds the address.Numbers (lane_measure, K30 scope): gt4 470 → 460, gt6 126 → 116 (this PR alone).
What ran (on the branch, which is current
origin/developmentplus these commits):vendor/bin/phpunit -c phpunit.xml --no-coverage tests/Unit/Architecture tests/Unit/Contract tests/Unit/Kernel tests/Unit/Service/Rules tests/Unit/Controller/ControllerServicesWiringTest.php tests/Unit/Controller/ControllerSessionWiringTest.php tests/Unit/Service/ExampleSet tests/Unit/Service/ConfigurationDeployment tests/Unit/Service/Vocabulary tests/Unit/Command— green;php -l,phpcs(no new errors or warnings) andphpstan(no errors) on every touched production file. All five K30 branches merge into development without conflicts.AI disclosure: written by Claude Code (Opus) as cloud lane K30 of round 10c (SIG unit interfacing, P1); reviewed by its own guards only.
Generated by Claude Code