Skip to content

[access] refactor(objects): a move reports to one bundle of audit trail and log - #7573

Merged
rubenvdlinde merged 1 commit into
mainfrom
cloud/k16-move-ctor
Nov 9, 2026
Merged

rubenvdlinde merged 1 commit into
mainfrom
cloud/k16-move-ctor

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Lane K16, round 10c — SIG unit interfacing.

What changed

  • MoveObject::__construct took five parameters. The audit trail and the logger do one job in it — reporting what a move did (the one moved audit entry, a stranded source row, an entry that could not be written) — and now arrive together as MoveReporting (a final class, two promoted readonly properties, autowired).
  • The object store, the validator and the event dispatcher that asks the guards of values other records hold stay direct parameters.
  • Types and field reads only ($this->reporting->audit, $this->reporting->logger): the audit entry, its context, the ordering of write-then-remove and every refusal are unchanged. The existing MoveObjectMoveGoldenTest, MoveObjectTest and MoveObjectUpdateGuardsTest pin those outcomes and still pass unchanged apart from the construction line.
  • Every test that builds a MoveObject (including BuildsMigrationHandler and MigrationHandlerRemovesSourceRowTest) follows the new shape.

What ran (on the branch merged with current development)

  • tests/Unit/Service/Object/ — 4243 tests OK (1 skipped, pre-existing)
  • --filter 'Move|Migration' tests/Unit — 1110 tests OK
  • tests/Unit/Architecture, tests/Unit/Contract, tests/Unit/Kernel, tests/Unit/Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest — 2658 tests OK
  • php -l, phpcs, phpstan on touched files — OK

Numbers

MoveObject::__construct (5 params, 8 NLOC) leaves the > 4 band. With #7507 and #7539 merged on one tree, the lane measure reads gt4 643 (target ≤ 661, was 722) and gt6 248 (target ≤ 263, was 287).

Written by an AI agent (Claude Code), reviewed by its own guards only.


Generated by Claude Code

MoveObject::__construct took five parameters. The audit trail and the
logger serve one purpose in it, reporting what the move did (the moved
entry, a stranded source row, an entry that could not be written), and
now arrive together as MoveReporting. The store, the validator and the
event dispatcher that asks the guards stay direct.

Assisted-by: ClaudeCode

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red, and the failure is not this PR's.

The job runs the full unit suite. It reports the same 11 errors and 11 failures as #7507 and #7539, in the same tests: JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest, A18InterfaceBindingsTest, TextExtractionJobsGoldenTest, EndpointsControllerAnswersGoldenTest, SchemaConfigValidatorsGoldenTest and ProcessingLogServiceGoldenTest. None of them builds or calls MoveObject or MoveReporting, and the move and migration tests (1110) pass locally on this branch.

The same api-test-coverage workflow is also red on development, at the merges of #7468 and #7469. I have no fix to port. This branch gets no further pushes; per the lane brief, an opened PR is finished.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Frontend Tests (unit) is red, and the failure is not this PR's.

One jest suite fails to load: src/components/shared/refreshButton.spec.js cannot parse src/components/shared/RefreshButton.vue (line 14). All 4971 tests in the other 239 suites pass. This PR changes no file under src/; it touches only lib/Service/Object/MoveObject.php, the new MoveReporting.php and the PHP tests that build MoveObject. The component and its spec came in from development.

The other quality checks red on #7507 and #7539 come from development the same way: l10n, parity, phpcs, eslint, format, psalm, phpstan, phpmd and the seven Hydra gates 3/7/12/17/40/46/49. For this PR's own files, the gate-122 ratchet reports 0 finding(s) across 4 changed units, and phpmd and phpcs report nothing. The fixes belong on development. This branch gets no further pushes; per the lane brief, an opened PR is finished.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Integration Tests (Newman) is red, and the failure is not this PR's.

1625 of 1628 assertions pass across all 39 collections, with 0 request or script errors. That is the same count as #7507, which changed RenderObject, not MoveObject. The one failure visible in the part of the log the API returns is also the same as on #7507: notify-on-change: no step failed — a step failed: expected 'n1: The call to source "d7e68c03-7d9e…' to deeply equal '', the flow's outbound call to a configured source. Two PRs that change different classes produce the identical result, so the failures come from the shared base, not from MoveObject/MoveReporting. The log API returns only the last 5,000 lines, so I cannot see the other two failing assertions, and I cannot re-run the job from here. This branch gets no further pushes; per the lane brief, an opened PR is finished.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 866bbec into main Nov 9, 2026
36 of 50 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 68620a4

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 17:33 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants