Repository navigation
[access] refactor(objects): a move reports to one bundle of audit trail and log - #7573
Conversation
MoveObject::__construct took five parameters. The audit trail and the logger serve one purpose in it, reporting what the move did (the moved entry, a stranded source row, an entry that could not be written), and now arrive together as MoveReporting. The store, the validator and the event dispatcher that asks the guards stay direct. Assisted-by: ClaudeCode
|
Newman API Test Suite is red, and the failure is not this PR's. The job runs the full unit suite. It reports the same 11 errors and 11 failures as #7507 and #7539, in the same tests: The same Generated by Claude Code |
|
One jest suite fails to load: The other Generated by Claude Code |
|
1625 of 1628 assertions pass across all 39 collections, with 0 request or script errors. That is the same count as #7507, which changed Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:33 UTC
Download the full PDF report from the workflow artifacts.
Lane K16, round 10c — SIG unit interfacing.
What changed
MoveObject::__constructtook five parameters. The audit trail and the logger do one job in it — reporting what a move did (the onemovedaudit entry, a stranded source row, an entry that could not be written) — and now arrive together asMoveReporting(afinalclass, two promoted readonly properties, autowired).$this->reporting->audit,$this->reporting->logger): the audit entry, its context, the ordering of write-then-remove and every refusal are unchanged. The existingMoveObjectMoveGoldenTest,MoveObjectTestandMoveObjectUpdateGuardsTestpin those outcomes and still pass unchanged apart from the construction line.MoveObject(includingBuildsMigrationHandlerandMigrationHandlerRemovesSourceRowTest) follows the new shape.What ran (on the branch merged with current
development)tests/Unit/Service/Object/— 4243 tests OK (1 skipped, pre-existing)--filter 'Move|Migration' tests/Unit— 1110 tests OKtests/Unit/Architecture,tests/Unit/Contract,tests/Unit/Kernel,tests/Unit/Service/Rules,ControllerServicesWiringTest,ControllerSessionWiringTest— 2658 tests OKphp -l,phpcs,phpstanon touched files — OKNumbers
MoveObject::__construct(5 params, 8 NLOC) leaves the > 4 band. With #7507 and #7539 merged on one tree, the lane measure reads gt4 643 (target ≤ 661, was 722) and gt6 248 (target ≤ 263, was 287).Written by an AI agent (Claude Code), reviewed by its own guards only.
Generated by Claude Code