Skip to content

[access] refactor(objects): render options travel as a selection, preloads and a path - #7539

Merged
rubenvdlinde merged 3 commits into
mainfrom
cloud/k16-render-options
Nov 9, 2026
Merged

rubenvdlinde merged 3 commits into
mainfrom
cloud/k16-render-options

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Lane K16, round 10c — SIG unit interfacing.

What changed

  • RenderContext::__construct took ten render options one by one. It now takes three value objects named after what they hold, plus the rbac flag:
    • RenderSelection — what the caller asks to see: extend, filter, fields, unset
    • RenderPreloads — what it already loaded: registers, schemas, objects
    • RenderPath — where the render is on its way down the relations: depth, visited ids
      Each is read by several render phases (renderWithContext, applyExtensions, applyInversedProperties, extendObject, sourceRefRun, primeRenderCaches). withExtend() rebuilds only the selection.
  • RenderObject::handleExtendDot took six parameters, three of which (depth, all-flag, visited ids) it copied straight into the ExtendDotRun it built. The caller now builds that run and hands it in: data, extend list, run, exposures. The nested wildcard pass gets a fresh run at the parent's depth (with the defaults it got before). The BooleanArgumentFlag suppression goes with the bool parameter.
  • No behaviour change: a null visited-id list still fails the same typed assignment it failed before, and the rbac flag is passed through unchanged.
  • Tests that build a RenderContext or call handleExtendDot follow the new shape.

What ran (on the branch merged with current development)

  • tests/Unit/Service/Object/ — 4243 tests OK (1 skipped, pre-existing)
  • tests/Unit/Architecture, tests/Unit/Contract, tests/Unit/Kernel, tests/Unit/Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest — 2658 tests OK
  • php -l, phpcs (0 errors; the one warning is the pre-existing missing class @spec), phpstan on touched files — OK

Numbers

RenderContext::__construct (10 params, 13 NLOC) leaves the > 4 and > 6 bands; handleExtendDot (6 params, 32 NLOC) leaves the > 4 band. renderEntity keeps its NLOC.

Written by an AI agent (Claude Code), reviewed by its own guards only.


Generated by Claude Code

…ited ids into handleExtendDot

handleExtendDot took six parameters; three of them (depth, all-flag,
visited ids) were copied straight into the ExtendDotRun it built. The
caller now builds that run and hands it in, so the method takes the data,
the extend list, the run and the exposures. The nested wildcard pass gets
a fresh run at the parent's depth, as before.

Assisted-by: ClaudeCode
… path

RenderContext took its ten render options one by one. They now come in
three value objects named after what they are: what the caller asks to
see (extend, filter, fields, unset), what it already loaded (registers,
schemas, objects) and where the render is on its way down the relations
(depth, visited ids), plus the rbac flag.

Assisted-by: ClaudeCode

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red, and the failure is not this PR's.

The job runs the full unit suite. It reports the same 11 errors and 11 failures as #7507, in the same tests: JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest, A18InterfaceBindingsTest (ObjectRetentionHandler), TextExtractionJobsGoldenTest, EndpointsControllerAnswersGoldenTest, SchemaConfigValidatorsGoldenTest and ProcessingLogServiceGoldenTest. None of them touches RenderContext, RenderObject or the new render value objects, and tests/Unit/Service/Object passes locally on this branch.

The same api-test-coverage workflow is also red on development, at the merges of #7468 and #7469. I have no fix to port. This branch gets no further pushes; per the lane brief, an opened PR is finished.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Frontend Check (test:l10n) is red, and the failure is not this PR's.

This PR changes no file under src/ or l10n/. node tests/l10n/check-l10n.js fails the same way on development itself: t()/n() keys in src/modals/object/MassValidateObjects.vue are missing from l10n/en.js. The same holds for test:l10n:parity (every locale is one key behind) and for the repo-wide phpcs, eslint, format, psalm and phpstan findings listed on #7507. None of them is in a file this PR changes. I checked this PR's own files for the two findings that #7507 does have: the gate-122 ratchet (check_sig_maintainability.py ratchet) reports 0 finding(s) across 15 changed units, and phpmd reports nothing for RenderContext, RenderSelection, RenderPreloads, RenderPath or the RenderObject changes. The fixes belong on development. This branch gets no further pushes; per the lane brief, an opened PR is finished.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Hydra Gates is red, and none of the failed gates is this PR's.

Seven gates fail: 3 stub-scan, 7 no-admin-idor (113 controller methods), 12 nc-input-labels, 17 redundant-controller, 40 form-label-association, 46 spec-anchor-existence and 49 controller-exception-translation. All seven report on controllers, Vue templates, stubs and spec anchors that this PR does not touch. #7507 fails the same seven. gate-122 (sig-maintainability), the one gate about this PR's own units and clones, passes here. The fixes belong on development. This branch gets no further pushes; per the lane brief, an opened PR is finished.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 92ee0d1 into main Nov 9, 2026
36 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 680f72b

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 15:18 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants