Repository navigation
[access] refactor(objects): render options travel as a selection, preloads and a path - #7539
Conversation
…ited ids into handleExtendDot handleExtendDot took six parameters; three of them (depth, all-flag, visited ids) were copied straight into the ExtendDotRun it built. The caller now builds that run and hands it in, so the method takes the data, the extend list, the run and the exposures. The nested wildcard pass gets a fresh run at the parent's depth, as before. Assisted-by: ClaudeCode
… path RenderContext took its ten render options one by one. They now come in three value objects named after what they are: what the caller asks to see (extend, filter, fields, unset), what it already loaded (registers, schemas, objects) and where the render is on its way down the relations (depth, visited ids), plus the rbac flag. Assisted-by: ClaudeCode
|
Newman API Test Suite is red, and the failure is not this PR's. The job runs the full unit suite. It reports the same 11 errors and 11 failures as #7507, in the same tests: The same Generated by Claude Code |
|
This PR changes no file under Generated by Claude Code |
|
Seven gates fail: 3 stub-scan, 7 no-admin-idor (113 controller methods), 12 nc-input-labels, 17 redundant-controller, 40 form-label-association, 46 spec-anchor-existence and 49 controller-exception-translation. All seven report on controllers, Vue templates, stubs and spec anchors that this PR does not touch. #7507 fails the same seven. gate-122 (sig-maintainability), the one gate about this PR's own units and clones, passes here. The fixes belong on Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 15:18 UTC
Download the full PDF report from the workflow artifacts.
Lane K16, round 10c — SIG unit interfacing.
What changed
RenderContext::__constructtook ten render options one by one. It now takes three value objects named after what they hold, plus the rbac flag:RenderSelection— what the caller asks to see: extend, filter, fields, unsetRenderPreloads— what it already loaded: registers, schemas, objectsRenderPath— where the render is on its way down the relations: depth, visited idsEach is read by several render phases (
renderWithContext,applyExtensions,applyInversedProperties,extendObject,sourceRefRun,primeRenderCaches).withExtend()rebuilds only the selection.RenderObject::handleExtendDottook six parameters, three of which (depth, all-flag, visited ids) it copied straight into theExtendDotRunit built. The caller now builds that run and hands it in: data, extend list, run, exposures. The nested wildcard pass gets a fresh run at the parent's depth (with the defaults it got before). TheBooleanArgumentFlagsuppression goes with the bool parameter.RenderContextor callhandleExtendDotfollow the new shape.What ran (on the branch merged with current
development)tests/Unit/Service/Object/— 4243 tests OK (1 skipped, pre-existing)tests/Unit/Architecture,tests/Unit/Contract,tests/Unit/Kernel,tests/Unit/Service/Rules,ControllerServicesWiringTest,ControllerSessionWiringTest— 2658 tests OKphp -l,phpcs(0 errors; the one warning is the pre-existing missing class@spec),phpstanon touched files — OKNumbers
RenderContext::__construct(10 params, 13 NLOC) leaves the > 4 and > 6 bands;handleExtendDot(6 params, 32 NLOC) leaves the > 4 band.renderEntitykeeps its NLOC.Written by an AI agent (Claude Code), reviewed by its own guards only.
Generated by Claude Code