Repository navigation
refactor(notifications): the example-set engine reaches the timeline writer through an interface - #7568
Merged
Conversation
…writer through an interface ExampleSetHistoryRowKinds typed the Notifications ExampleSetTimelineEntries class. It now takes ExampleSetTimelineRowsInterface (rows() hands the writer back as the engine's ExampleSetEngineRows, the pattern ExampleSetViewRowsInterface uses), bound in NotificationsWiring so the autowired optional writer still resolves to the same class. The registrar's pinned alias count goes from 25 to 26 for that one binding; K07InterfaceBindingsTest pins the binding and that the caller names only the interface. Assisted-by: ClaudeCode:claude-opus-5-5
…line-rows # Conflicts: # lib/Notifications/NotificationsWiring.php
Resolve the golden-test conflict: main stubs rows() on ExampleSetViewRowsInterface doubles, this branch on ExampleSetTimelineRowsInterface doubles; the writer double now stubs it for either. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lane K07, round 10c, component independence.
What changed
Notifications\Service\ExampleSet\ExampleSetTimelineRowsInterface(rows(): ExampleSetEngineRows), implemented byExampleSetTimelineEntries(rows()returns$this). This is the same pattern asExampleSetViewRowsInterfacein [access] refactor(search): the example-set views writer, the index rebuild job and the vector rows stay inside Search #7447.Service\ExampleSet\ExampleSetHistoryRowKindsnow types?ExampleSetTimelineRowsInterfaceand hands->rows()to the engine, so lib/Service no longer names the Notifications class.ExampleSetTimelineRowsInterface => ExampleSetTimelineEntriesadded toNotificationsWiring::BINDINGS, so the autowired optional writer still resolves to the same shared class. Without the binding it would quietly fall back tonulland refuse the part.K07InterfaceBindingsTest(new) pins the binding, checks the class implements the interface, and checks the caller names only the interface. TheNotificationsRegistrarTestpinned alias count goes from 26 to 27 for this one binding. In the golden and bundle tests, the writer doubles now answerrows()with themselves.What ran (branch merged with current development)
tests/Unit/Architecture,tests/Unit/Contract,tests/Unit/Kernel,tests/Unit/Service/Rules,ControllerServicesWiringTest,ControllerSessionWiringTest,tests/Unit/Service/ExampleSet,tests/Unit/Service/Flow,tests/Unit/Notifications: OK (5532 tests).Numbers (lane_measure K07)
Exposed LOC for K07 classes: 604 on development, 480 with this PR (
ExampleSetTimelineEntries, 124 LOC, is now hidden). Interfacing is unchanged (gt4 128, gt6 0).AI-assisted: written by Claude Code (Opus 5.5).
Generated by Claude Code