Repository navigation
[access] refactor(search): the example-set views writer, the index rebuild job and the vector rows stay inside Search - #7447
Conversation
Assisted-by: ClaudeCode
… and the vector rows stay inside Search Outside lib/Search, three files named Search classes: - ExampleSetOwnRowKinds typed its views writer as ExampleSetViews. It now takes ExampleSetViewRowsInterface (bound in SearchWiring to ExampleSetViews, so autowiring resolves the same writer), whose rows() hands the engine the ExampleSetEngineRows it already drives. - OperationsJobsService named SearchIndexRebuildJob::class in its run-now allowlist. It now names SearchJobHandles::SEARCH_INDEX_REBUILD, the same string (pinned as a literal by MaintenanceActionsGoldenTest, added first). - ChunkVectorizationBatch built StoredVector from VectorSubject, VectorPayload and VectorChunkPosition. The same construction moved to ChunkVectorFactory (strict, as its source), reached through ChunkVectorFactoryInterface from the container the batch already reads; the per-batch chunk count stays in the batch. SearchRegistrarTest counts the bindings: 17 to 19. H11InterfaceBindingsTest pins both bindings and that the three callers no longer name the classes. Assisted-by: ClaudeCode
|
Newman API Test Suite (
No fix exists yet. It belongs in its own PR, not this one. I could not re-run the job from this session. Generated by Claude Code |
|
quality / Frontend Check (format) and quality / Vue Quality (eslint) failed, but this PR didn't cause it. Both checks look only at frontend code ( Generated by Claude Code |
|
Three more frontend checks failed: quality / Frontend Tests (unit), Frontend Check (test:l10n) and Frontend Check (test:l10n:parity). This PR didn't cause them. These checks look only at
The fixes belong in their own frontend and l10n PRs. I couldn't re-run the jobs from this session. Generated by Claude Code |
|
quality / PHP Quality (phpstan) failed, but this PR didn't cause it. It reports the same 24 errors as on #7444, in the same 12 files. None of those files are in this diff:
This PR's own files raise nothing. The fix belongs in its own PR against Generated by Claude Code |
|
quality / PHP Quality (phpcs) failed, but this PR did not cause it. It flags the same 8 files as on #7444, none of which this diff touches: Generated by Claude Code |
|
quality / PHP Quality (psalm) failed, but this PR didn't cause it. It reports 54 errors in 32 files, the same failure as on #7444. That includes type mismatches in Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 01:38 UTC
Download the full PDF report from the workflow artifacts.
…hunk entity forChunk() now takes the chunk's source type and id, index, text and offsets, so lib/Search no longer names OCA\OpenRegister\Files\Db\Chunk and the H15 guard holds. The vector row it builds is unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
The chunk's source type and id, index, text and offsets travel in one readonly ChunkVectorSource owned by the Search vectorization code, so forChunk() takes three parameters instead of eight. It still does not name the Chunk entity, and the vector row it builds is unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49041/49051 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 07:16 UTC
Download the full PDF report from the workflow artifacts.
Lane H11, round 10b (SIG component independence).
What changed
Three files outside
lib/Searchnamed concrete Search classes. They now name only an interface or a handle.ExampleSetOwnRowKindstyped its views writer asExampleSetViews. It now takesExampleSetViewRowsInterface, which is bound inSearchWiringtoExampleSetViews, so autowiring resolves the same shared writer. The interface's single method,rows(), gives the engine theExampleSetEngineRowsit already drives.OperationsJobsServicenamedSearchIndexRebuildJob::classin its run-now allowlist. It now namesSearchJobHandles::SEARCH_INDEX_REBUILD, which is the same string. This follows thelib/BackgroundJob/JobHandlespattern.[access]prefix because this allowlist decides which classes run-now may start; its value is unchanged and pinned.ChunkVectorizationBatchbuiltStoredVectorfromVectorSubject,VectorPayloadandVectorChunkPosition. That same construction moved toChunkVectorFactory(strict, like its source), reached throughChunkVectorFactoryInterfacefrom the container the batch already reads. The per-batch chunk-count memo stays in the batch.SearchWiring::BINDINGS.Tests
MaintenanceActionsGoldenTestfirst, against the old code. It pins the allowlist as literal class strings.H11InterfaceBindingsTestchecks that both bindings are present, that each bound class implements its interface, and that the three callers no longer name the hidden classes.SearchRegistrarTestbinding count goes from 17 to 19. The existing chunk-vectorization golden passes with the factory registered on its container. TheExampleSetOwnRowKindsand engine-kinds tests setrows()on theirExampleSetViewsdoubles.ExampleSetEngineKinds.Numbers (lane_measure, H11, all lane branches merged)
ExampleSetViews(182),SearchIndexRebuildJob(32),StoredVector(30),VectorChunkPosition(11),VectorPayload(11) andVectorSubject(10) are now hidden.AI-assisted: this change was written by Claude Code (an AI agent), working the H11 lane brief.
Generated by Claude Code