Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
- [x] 4. `AttentionWidget.vue` and its form, registered as `attention`, added to `lib/widget-types.json`. Verify: Vitest for the four states (items, nothing, failed, none declared).
- [x] 5. `en` and `nl` strings.
- [x] 6. "Mijn werkdag" version 2 with the widget on top. Verify: `ShippedTemplateServiceTest`.
- [ ] 7. Live check in a browser with at least one app carrying the file. Not done in this change's PR.
- [x] 7. Live check in a browser with at least one app carrying the file. Done 17 Nov 2026 on a live NC 34 rig with OpenRegister 2.1.47 and pipelinq 0.5.21 (which ships `appinfo/attention.json`): for a member of `sales` with one ticket in progress past its deadline, "Vandaag eerst" showed "1 thing from all your apps that needs attention today", "Tickets past their deadline" with the reason and "Open these tickets". The count asked `assignee=werker&status=in_progress&slaDeadline[lt]=2026-11-18&_limit=1`, the link was `/apps/pipelinq/tickets?assignee=@me&status=in_progress&slaDeadline[lt]=@today%2B1d` and opens. Without pipelinq it read "None of your apps reports attention items yet.", and with the ticket out of the member's reach "Nothing needs your attention right now."
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
## Close

- [x] 11. Add the three demo announcements. Verify: PHPUnit on the showcase.
- [ ] 12. Playwright for the notice flow and a liked, commented news item.
- [ ] 13. Add `nl` and `en` strings, copy the spec to `openspec/specs/announcements/spec.md` on archive, and set e-announcements, d-news-preview and e-maintenance to `built` in the parity matrix with evidence lines.
- [x] 12. Playwright for the notice flow and a liked, commented news item. Done 17 Nov 2026: `tests/e2e/announcements.spec.ts`, 3 passed on a live NC 34 rig (notice without an end time refused, warning banner without a close button, an info notice dismissed and gone after reload, a news item liked and commented, both counts after reload).
- [x] 13. Add `nl` and `en` strings, copy the spec to `openspec/specs/announcements/spec.md` on archive, and set e-announcements, d-news-preview and e-maintenance to `built` in the parity matrix with evidence lines. Done on archive 17 Nov 2026: the spec is `openspec/specs/announcements/spec.md`, and e-announcements, d-news-preview and e-maintenance point at it with the e2e evidence.

Built: tasks 1 to 11. Backend: `AnnouncementTablesBuilder` and migration `Version002013Date20261114000000`, `Announcement`/`AnnouncementFollow` with their mappers, `AnnouncementService` (with "Preview as" through `reachesUser()`), `AnnouncementInput`, `AnnouncementFollowService`, `AnnouncementCommentService` (likes and comments through `ICommentsManager`, object type `launchpad_announcement`), `AnnouncementFollowNotifier` and `AnnouncementNotifyJob` (`announcement_published`, once per announcement through `notified_at`), `DemoAnnouncements` (seeded with the demo data), `AnnouncementController` with thirteen routes, the four `announcement.*` actions, and `announcementEditorGroups` in the admin settings API. Frontend: the `announcements` widget and its form, `AnnouncementCard`, `NoticeBanner` and `NoticeBannerRegion` above the Workspace grid, `AnnouncementEditorModal` with the preview step, and the editor groups picker in Beheer > Sharing.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
- [x] Task 6: Run `npm run lint` and confirm the new guard passes with
zero violations after Task 2's fixes. 9 Oct: `node scripts/lint-translation-domain.js`
prints OK, exit 0.
- [ ] Task 7: Manually verify in a Dutch-locale (`nl`) Nextcloud session:
- [x] Task 7: Manually verify in a Dutch-locale (`nl`) Nextcloud session: Done 17 Nov 2026 on a live NC 34 rig as an `nl` administrator: the Operations tab heading reads "Status" with "Gezond"/"Verminderd", and the widget context menu reads "Zichtbaarheidsregels…".
open the admin Health panel (`HealthPanel.vue`) and the widget
right-click context menu (`WidgetContextMenu.vue`) and confirm the
previously-English "Health"/"Healthy"/"Degraded" and "Visibility
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
- [x] 3. Add `PlacementService::importBookmarks()`: URL check per bookmark, one quota check, containers for folders, bottom-append, one transaction, a skipped list in the response. Verify: PHPUnit including rollback.
- [x] 4. Write the browser parser for the Netscape bookmark format with size and count limits. Verify: Vitest on Firefox, Chrome and Edge fixtures.
- [x] 5. Build `src/modals/BookmarkImportModal.vue` (file picker, folder and bookmark checkboxes, skipped list) and the "Import bookmarks" entry in the dashboard menu. Verify: Vitest and an axe check.
- [ ] 6. Playwright: import a fixture, pick one folder, see its container at the bottom.
- [ ] 7. Add `nl` and `en` strings, fold the delta into `openspec/specs/tiles/spec.md` on archive, and set d-import-bookmarks to `built` in the parity matrix with evidence lines.
- [x] 6. Playwright: import a fixture, pick one folder, see its container at the bottom. Done 17 Nov 2026: `tests/e2e/bookmark-import.spec.ts`, passed on a live NC 34 rig (reached through More, All dashboards, the row menu; the script bookmark is skipped).
- [x] 7. Add `nl` and `en` strings, fold the delta into `openspec/specs/tiles/spec.md` on archive, and set d-import-bookmarks to `built` in the parity matrix with evidence lines. Done on archive 17 Nov 2026: the delta is folded into `openspec/specs/tiles/spec.md`, and d-import-bookmarks is `built` with evidence lines.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
- `ContainerWidget.vue` shows `displayedChildren`: the stored layout in edit mode or by hand, otherwise sorted (`sortChildren`) and reflowed row by row (`reflowChildren`), sizes kept. A grid change is not persisted while a sorted view is shown. Random draws once per page load. Vitest: `tileSort.spec.js` per mode and `ContainerWidget.sort.spec.js`.
- [x] 4. Add "Forget my usage" to the container menu and the "Sorted by" accessible description. Verify: Vitest and an axe check.
- Done, with two notes. The container has no menu of its own, so "Forget my usage" is a tertiary button in its header, shown in view mode for most and last used. The grid is `aria-describedby` a visually hidden "Sorted by …" line. Vitest covers both; the axe check is still owed and needs the live page.
- [ ] 5. Playwright: most used moves a clicked tile to the front after reload; "By hand" restores the stored layout.
- [ ] 6. Add `nl` and `en` strings, fold the delta into `openspec/specs/container-widget/spec.md` on archive, and set d-tile-sort and tile-most-used to `built` in the parity matrix with evidence lines.
- [x] 5. Playwright: most used moves a clicked tile to the front after reload; "By hand" restores the stored layout. Done 17 Nov 2026: `tests/e2e/container-tile-sorting.spec.ts`, 2 passed on a live NC 34 rig. It seeds the container through the bookmark import, so the children carry no id, and it was red until `ContainerWidget` keyed such children by the container (they were never counted).
- [x] 6. Add `nl` and `en` strings, fold the delta into `openspec/specs/container-widget/spec.md` on archive, and set d-tile-sort and tile-most-used to `built` in the parity matrix with evidence lines. Done on archive 17 Nov 2026: the delta is folded into `openspec/specs/container-widget/spec.md`, and d-tile-sort and tile-most-used are `built` with evidence lines.
- Partly: the Dutch strings are in `l10n/nl.js` and `l10n/nl.json`, and English is the source. They are deliberately not added to `en.*`: the parity gate would then require all 36 locales. The other locales fall back to English. Folding the delta into the spec, and setting the parity rows to `built`, belong to archive and merge.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
schema: spec-driven
skip_specs: true
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
- [x] 5. `occ launchpad:template:install`, registered in `appinfo/info.xml`. Verify: `TemplateInstallCommandTest`.
- [x] 6. `GET /api/admin/templates/shipped` and `POST /api/admin/templates/shipped/{id}/install`. Verify: `AdminShippedTemplateControllerTest`.
- [x] 7. Templates page: ready-made templates section and a download per template, `en` and `nl` strings. Verify: `TemplatesPage.shipped.spec.js`.
- [ ] 8. Live check in a browser on a running instance. Not done in this change's PR: see the PR body.
- [x] 8. Live check in a browser on a running instance. Done 17 Nov 2026 (live pass, NC 34.0.6 + OpenRegister 2.1.47 rig): the Templates page lists "Mijn werkdag" under Ready-made templates with the registers its lists read; `occ launchpad:template:install mijn-werkdag -g werkdag` installed it, and a new member of `werkdag` got their copy on the first visit and saw it in the browser.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
schema: spec-driven
skip_specs: true
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
- [x] 1. `hideWhenUnavailable`: the page asks OpenRegister once per source and leaves a 404 list out, outside edit mode. Verify: `ViewsHideUnavailableSource.spec.js`.
- [x] 2. Template version 3 with "Mijn tickets" and "Wacht op uw stem", every list hideable. Verify: `ShippedTemplateServiceTest::testTheShippedDefinitionIsWellFormed`, `::testAShippedTemplateRendersAsInstalled` with the two new register fixtures.
- [x] 3. Listing, Templates page and command name the registers the lists read. Verify: `ShippedTemplateServiceTest::testTheListingNamesWidgetsNothingRegisters`, `TemplatesPage.shipped.spec.js`, `TemplateInstallCommandTest::testInstallsForAGroup`.
- [ ] 4. Live: update an instance from version 2 with `--update`, see a member's page without pipelinq and decidiq. See the PR body.
- [x] 4. Live: update an instance from version 2 with `--update`, see a member's page without pipelinq and decidiq. Done 17 Nov 2026 (live pass): version 2 installed for `werkdag`, a member visited, then `--update --dry-run` and `--update` brought it to version 5 (the version shipped now) and the member's copy followed ("Copies changed: 1"). In the browser the member sees Vandaag, Vandaag eerst, Apps, Agenda vandaag and Verder waar u was; the dossiq, pipelinq and decidiq stat widgets are left out (OpenRegister answers 404, none of the three is installed) and no "Could not load" line shows.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
schema: spec-driven
skip_specs: true
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@
- [x] 6. Templates page: "Update to version N" and the confirmation dialog, `en` and `nl` strings. Verify: `TemplatesPage.shippedUpdate.spec.js`.
- [x] 7. `getApplicableTemplate()` picks by one rule. Verify: `TemplateServiceApplicableTemplateTest`.
- [x] 8. Live check of the command on a test instance, and of a member's page in a browser afterwards. See the PR body.
- [ ] 9. Open the "Update to version N" button and its dialog in a browser. Not done in this change's PR: see the PR body.
- [x] 9. Open the "Update to version N" button and its dialog in a browser. Done 17 Nov 2026 (live pass): with version 2 on record, the Templates page showed "Update to version 5"; the dialog listed the widgets added, removed and changed and the member copies, and "Update" applied it and the button went away.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
schema: spec-driven
skip_specs: true
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

- [x] 1. The option: key, default off, persistence, controller parameter, initial-state setter and wiring. Verify: `AdminSettingsServiceTest::testGetSettingsStartPageWithoutNavigationDefaultsOff`, `::testUpdateSettingsPersistsStartPageWithoutNavigation`, `InitialStateBuilderTest`, `AdminControllerSettingsAliasTest::testStartPageWithoutNavigationIsPassedThrough`.
- [x] 2. The dashboard view without the panel, the menu in the top row, the admin switch, strings in 37 locales. Verify: `App.navigationPanel.spec.js`, `StartPageMenu.spec.js`.
- [ ] 3. Live: option on, a member's start page without the panel, the menu with every destination; option off, the panel back. See the PR body.
- [x] 3. Live: option on, a member's start page without the panel, the menu with every destination; option off, the panel back. Done 17 Nov 2026: `tests/e2e/start-page-without-navigation.spec.ts`, 3 passed on a live NC 34 rig. The menu is now the More menu (lpvandaag-start-page), so the spec was moved from `launchpad-start-page-menu` to it.
Loading
Loading