Skip to content

fix(launchpad): count id-less container tiles; e2e and archives from the live pass - #1271

Merged
rubenvdlinde merged 5 commits into
developmentfrom
quality/livepass-launchpad-2
Nov 17, 2026
Merged

rubenvdlinde merged 5 commits into
developmentfrom
quality/livepass-launchpad-2

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Live pass on launchpad: one defect fixed, three new e2e specs, one stale e2e spec moved to the current UI, and nine changes archived.

The defect

A container sorted "Most used" or "Last used" never moved. It counts each tile by its id or uuid, and the bookmark import (the one path that writes a container with children) writes children with neither, so recordTileUse('') returned without counting. ContainerWidget now gives such a child <container id>-<index> as its uuid. Vitest counts children a bookmark import wrote without an id is red without the fix, and tests/e2e/container-tile-sorting.spec.ts (which seeds the container through the import) was red on the rig before it.

Tests

  • tests/e2e/container-tile-sorting.spec.ts: most used moves a tile opened three times to the front after a reload, "by hand" restores the stored order.
  • tests/e2e/bookmark-import.spec.ts: import a bookmarks file through More, All dashboards and the row menu, tick one folder; one container with its three web bookmarks lands below the existing tile, the script bookmark is skipped.
  • tests/e2e/announcements.spec.ts: a notice without an end time is refused, a warning notice is a banner without a close button, an info notice is dismissed and stays gone after a reload, a news item is liked and commented and the counts survive a reload.
  • tests/e2e/start-page-without-navigation.spec.ts looked for launchpad-start-page-menu, which LpVandaag replaced with the More menu. It now checks the More menu.

Archived

mijn-werkdag-template, shipped-template-update, mijn-werkdag-v3, start-page-without-navigation-panel, fix-l10n-domain-mismatch-mydash-calls, launcher-tile-sorting, launcher-bookmark-import, engagement-announcements and cross-app-attention-feed. Their last tasks were live checks, done on a throwaway NC 34.0.6 instance with OpenRegister 2.1.47 (and pipelinq 0.5.21 for the attention feed). Each task line says what was seen. Four changes had their requirements written straight into the main specs, so they carry skip_specs, and cross-app-attention-feed was archived with --skip-specs because its delta matches openspec/specs/attention-feed exactly. New main specs announcements and i18n-translation-domain have a Purpose. In the parity matrix d-tile-sort, tile-most-used and d-import-bookmarks are now built with evidence, and the other rows point at the archived changes.

What ran locally

  • The 9 tests in the four specs above: all passed against the rig.
  • Vitest on the container specs: 35 passed.
  • eslint on the changed files: clean.
  • composer check:strict once: phpstan clean and PHPUnit green (4621 tests, 13 skipped). phpcs (warnings), phpmd and psalm fail on development as well, and this PR changes no PHP.
  • npm run lint: 2 errors in src/components/Announcements/__tests__/announcements.spec.js, a file this PR does not touch. They fail on development too.

Seen, not fixed here

  • About 20 e2e files still use .launchpad-sidebar-toggle or launchpad-start-page-menu. Both went away with LpVandaag on 26 Oct. active-dashboard-resolution fails 2 of 3 on the rig for that reason. CI's E2E job does not run on development, so nothing flagged it.
  • composer install fails on development since the psalm 7.6 bump: config.platform.php is 8.3, which composer reads as 8.3.0, and psalm 7.6 needs 8.3.16 or later. The check above ran with the vendor from before the bump.
  • Code @spec tags still name openspec/changes/<change>/specs/... for the archived changes, as they did after earlier archives.

Assisted-by: ClaudeCode:claude-opus-5-5

A container sorted by most used or last used counts each tile by its id or
uuid. The bookmark import writes container children with neither, so their
use was never recorded and the order never moved. Children without a key now
take <container id>-<index> as their uuid.

Vitest (red without the fix) and tests/e2e/container-tile-sorting.spec.ts,
which seeds the container through the bookmark import.

Assisted-by: ClaudeCode:claude-opus-5-5
…e on the More menu

bookmark-import.spec.ts imports one folder of a bookmarks file through the row
menu and checks the container lands at the bottom. announcements.spec.ts covers
the notice banner, dismissing, the end-time refusal, and a liked and commented
news item. start-page-without-navigation.spec.ts now reads the More menu,
which replaced the start page menu with lpvandaag-start-page.

Assisted-by: ClaudeCode:claude-opus-5-5
Live checks on a throwaway NC 34 + OpenRegister instance ticked the last
tasks of mijn-werkdag-template, shipped-template-update, mijn-werkdag-v3,
start-page-without-navigation-panel and fix-l10n-domain-mismatch-mydash-calls,
and new e2e specs ticked launcher-tile-sorting, launcher-bookmark-import and
engagement-announcements. All eight are archived; the four whose requirements
were already written into the main specs carry skip_specs.

Deltas folded into container-widget and tiles, new main specs announcements
and i18n-translation-domain with a Purpose each. Parity rows d-tile-sort,
tile-most-used and d-import-bookmarks are built with evidence; the
announcement rows and the rest point at the archived changes and main specs.

Assisted-by: ClaudeCode:claude-opus-5-5
…with pipelinq

First today listed a member's overdue pipelinq ticket with a link that opens
the list, on NC 34 with OpenRegister 2.1.47 and pipelinq 0.5.21. Its
requirements were already the main spec attention-feed, so it is archived
without a spec update.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 24528e5 into development Nov 17, 2026
7 of 8 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 84ba83d

Check PHP Vue Security License Tests
lint ❌
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ❌
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ❌
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 12:50 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant