Repository navigation
fix(launchpad): count id-less container tiles; e2e and archives from the live pass - #1271
Merged
Merged
Conversation
A container sorted by most used or last used counts each tile by its id or uuid. The bookmark import writes container children with neither, so their use was never recorded and the order never moved. Children without a key now take <container id>-<index> as their uuid. Vitest (red without the fix) and tests/e2e/container-tile-sorting.spec.ts, which seeds the container through the bookmark import. Assisted-by: ClaudeCode:claude-opus-5-5
…e on the More menu bookmark-import.spec.ts imports one folder of a bookmarks file through the row menu and checks the container lands at the bottom. announcements.spec.ts covers the notice banner, dismissing, the end-time refusal, and a liked and commented news item. start-page-without-navigation.spec.ts now reads the More menu, which replaced the start page menu with lpvandaag-start-page. Assisted-by: ClaudeCode:claude-opus-5-5
Live checks on a throwaway NC 34 + OpenRegister instance ticked the last tasks of mijn-werkdag-template, shipped-template-update, mijn-werkdag-v3, start-page-without-navigation-panel and fix-l10n-domain-mismatch-mydash-calls, and new e2e specs ticked launcher-tile-sorting, launcher-bookmark-import and engagement-announcements. All eight are archived; the four whose requirements were already written into the main specs carry skip_specs. Deltas folded into container-widget and tiles, new main specs announcements and i18n-translation-domain with a Purpose each. Parity rows d-tile-sort, tile-most-used and d-import-bookmarks are built with evidence; the announcement rows and the rest point at the archived changes and main specs. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…with pipelinq First today listed a member's overdue pipelinq ticket with a link that opens the list, on NC 34 with OpenRegister 2.1.47 and pipelinq 0.5.21. Its requirements were already the main spec attention-feed, so it is archived without a spec update. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
November 17, 2026 12:12
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-17 12:50 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live pass on launchpad: one defect fixed, three new e2e specs, one stale e2e spec moved to the current UI, and nine changes archived.
The defect
A container sorted "Most used" or "Last used" never moved. It counts each tile by its
idoruuid, and the bookmark import (the one path that writes a container with children) writes children with neither, sorecordTileUse('')returned without counting.ContainerWidgetnow gives such a child<container id>-<index>as its uuid. Vitestcounts children a bookmark import wrote without an idis red without the fix, andtests/e2e/container-tile-sorting.spec.ts(which seeds the container through the import) was red on the rig before it.Tests
tests/e2e/container-tile-sorting.spec.ts: most used moves a tile opened three times to the front after a reload, "by hand" restores the stored order.tests/e2e/bookmark-import.spec.ts: import a bookmarks file through More, All dashboards and the row menu, tick one folder; one container with its three web bookmarks lands below the existing tile, the script bookmark is skipped.tests/e2e/announcements.spec.ts: a notice without an end time is refused, a warning notice is a banner without a close button, an info notice is dismissed and stays gone after a reload, a news item is liked and commented and the counts survive a reload.tests/e2e/start-page-without-navigation.spec.tslooked forlaunchpad-start-page-menu, which LpVandaag replaced with the More menu. It now checks the More menu.Archived
mijn-werkdag-template, shipped-template-update, mijn-werkdag-v3, start-page-without-navigation-panel, fix-l10n-domain-mismatch-mydash-calls, launcher-tile-sorting, launcher-bookmark-import, engagement-announcements and cross-app-attention-feed. Their last tasks were live checks, done on a throwaway NC 34.0.6 instance with OpenRegister 2.1.47 (and pipelinq 0.5.21 for the attention feed). Each task line says what was seen. Four changes had their requirements written straight into the main specs, so they carry
skip_specs, and cross-app-attention-feed was archived with--skip-specsbecause its delta matchesopenspec/specs/attention-feedexactly. New main specsannouncementsandi18n-translation-domainhave a Purpose. In the parity matrix d-tile-sort, tile-most-used and d-import-bookmarks are nowbuiltwith evidence, and the other rows point at the archived changes.What ran locally
composer check:strictonce: phpstan clean and PHPUnit green (4621 tests, 13 skipped). phpcs (warnings), phpmd and psalm fail ondevelopmentas well, and this PR changes no PHP.npm run lint: 2 errors insrc/components/Announcements/__tests__/announcements.spec.js, a file this PR does not touch. They fail ondevelopmenttoo.Seen, not fixed here
.launchpad-sidebar-toggleorlaunchpad-start-page-menu. Both went away with LpVandaag on 26 Oct.active-dashboard-resolutionfails 2 of 3 on the rig for that reason. CI's E2E job does not run ondevelopment, so nothing flagged it.composer installfails ondevelopmentsince the psalm 7.6 bump:config.platform.phpis8.3, which composer reads as 8.3.0, and psalm 7.6 needs 8.3.16 or later. The check above ran with the vendor from before the bump.@spectags still nameopenspec/changes/<change>/specs/...for the archived changes, as they did after earlier archives.Assisted-by: ClaudeCode:claude-opus-5-5