Repository navigation
feat(launchpad): build launcher-tile-open-behaviour - #1217
Open
rubenvdlinde wants to merge 8 commits into
Open
rubenvdlinde wants to merge 8 commits into
rubenvdlinde wants to merge 8 commits into
Conversation
A tile can open in the same tab, a new tab or a panel beside the tiles, chosen per tile in the tile editor; a tile without a choice follows the dashboard's default, and a dashboard without one keeps the old rule (web address in a new tab, app in the same tab). The panel frames an address on this Nextcloud directly and an outside one only after the server's framing check, falling back to an "Open in new tab" card. Quick search opens a side-panel tile in the panel too. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 14, 2026 08:40
…our [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
…n [skip ci] #1212 adds lib/Migration/Version002013Date20261114090000.php for the app catalogue and this branch added a different migration under the same class name, with the same app version. Whichever landed second would collide, and on an instance already at that version its migration would never run. This branch's migration becomes Version002014Date20261114100000 and the app version 1.1.7-unstable.20261114100000. Assisted-by: ClaudeCode:claude-opus-5-5
…our [skip ci] Development's launcher-tile-launch-types overlaps this line in the tile code. A launch type's own target (program, remote desktop, sso) wins in the tile anchor, else the resolved open-in target; a create tile opens its dialog, a side-panel tile the panel. A new tile stores its content and link target before the launch link is checked, and the create patch also carries the link target. Both sides' tests and Dutch strings are kept; the app version moves past development's so the branch's migration runs. Assisted-by: ClaudeCode:claude-opus-5-5
…ip ci] Keeps the branch's app version 1.1.7-unstable.20261117010000, above development's. Assisted-by: ClaudeCode
…c [skip ci] tilePanel open/close, isLinkTarget, resolveLinkTarget, isSameOrigin and TileSidePanel's setup and url watcher now carry @SPEC links to their requirement, so the spec-coverage check passes on this change. Assisted-by: ClaudeCode:claude-opus-5-5
…e body [skip ci] DashboardApiController::update read defaultLinkTarget as a ninth argument and decided metadata-only inline, which raised its complexity to 11 and its parameter count to 9. The value is now read from the request body like the controller's other optional fields, and the metadata-only decision is its own helper. A non-string value is ignored. New tests pin that a link target change asks the full edit permission and is refused without it. Assisted-by: ClaudeCode:claude-opus-5-5
…ip ci] Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/launcher-tile-open-behaviour(rowsd-link-target,d-open-inside).Tasks done
lib/Service/TileLinkTarget.phpholdssame-tab/new-tab/side-paneland the resolution order.TileUpdaterrefuses any other value on create (linkTarget, now read byRequestDataExtractor) and on update (content.linkTarget), which the placement endpoint answers with 400.Version002013Date20261114090000adds a nullabledefault_link_target(app version bumped to…20261114090000, also inopenapi.json),Dashboard::defaultLinkTarget, andDashboardService::updateDashboard()validates it; an empty value clears it.PUT /api/dashboard/{id}takesdefaultLinkTarget; like placements, it needs full edit rights, not metadata rights.validateIframeUrlrefuses an outside host, and that choice is dropped.tilePanelpinia store rather than anopen-in-panelevent chain throughViews; edit mode never opens it.Tasks left
TileSidePanelis built and unit-tested: one panel, close button, Escape, focus return, framing check with the "Open in new tab" fallback, overlay below 768px. The Playwright run needs a live instance.enis sparse in this repo, and adding keys there would require all 36 parity locales. The spec update and thecapabilities.jsonrows belong to the archive step.Tests
TileLinkTargetTest,TileUpdaterTest(+3),DashboardServiceLinkTargetTest,Version002013Date20261114090000Test. Serialise/golden fixtures re-recorded; their only change is the newdefaultLinkTargetkey, andRequestDataExtractorTestaddslinkTarget.tileLinkTarget,tilePanel,TileWidget.linkTarget,TileSidePanel,TileEditor.opensIn,DashboardConfigModal.linkTarget,useTileSearchHost.sidePanel. Three existing specs adjusted for the new markup and field; the props golden gains the two new props.TileUpdater); eslint clean;check:l10n-parityOK.Generated by Claude Code