Skip to content

feat(launchpad): build launcher-app-catalogue - #1212

Merged
rubenvdlinde merged 16 commits into
developmentfrom
quality/build-launcher-app-catalogue
Nov 17, 2026
Merged

rubenvdlinde merged 16 commits into
developmentfrom
quality/build-launcher-app-catalogue

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Builds openspec change launcher-app-catalogue (REQ-ACAT-001..004), partly: the backend, the add-flow section and the request form. The admin section and the locale strings follow.

Tasks done

  • 2 catalogue.list and catalogue.request (["admin", "@all"]), catalogue.manage and catalogue.decide (["admin"]) in lib/actions.seed.json, each wired to requireAction(); the action baseline test lists them.
  • 3 CatalogueService: group-filtered list (through AdminTemplateService::getUserGroupIdsFor, the one place allowed to read groups), create/update/delete with validation (http(s) address or Nextcloud app id), request with the 10-open limit, approve (prefills the requested name, links the request to the new entry) and decline (note required).
  • 4 CatalogueController (GET /api/catalogue, POST /api/catalogue/requests, 429 with code request_limit) and AdminCatalogueController (CRUD, approve, decline, manager group), every admin method #[AuthorizedAdminSetting(LaunchPadAdmin::class)] plus an admin check and its action. Routes and openapi.json entries added.
  • 5 Notifier renders app_requested (to every administrator and the members of the optional catalogue_manager_group) and app_request_decided (approved, or declined with the note), linking to the admin section and to LaunchPad.
  • 6 "From the app catalogue" in WidgetPickerModal, above the widget list and filtered by the same search box; one click places an ordinary tile through the existing tile path (tileFromCatalogueApp).
  • 9 CatalogueService::seedDemoEntries() (Zaaksysteem, Personeelsportaal, Bestanden, Agenda, for everyone) runs on a showcase install when the catalogue is empty; a failure is logged and does not undo the install.

Done in code, left unchecked

  • 1 Migration Version002013Date20261114090000 with both tables, entities and mappers (mapper query golden recorded). Open: running it on PostgreSQL and MySQL, which needs live databases.
  • 7 "Can't find your app?" form in the picker (sent / limit / failure messages), with Vitest. Open: the axe check, which needs a browser.

Left

  • 8 The admin "App catalogue" section. The admin API it needs is in this PR.
  • 10 Playwright.
  • 11 Strings: the locale parity gate requires every key in all 36 locales, so the strings go in with the admin section; until then the new texts show in English. Archive and matrix update come at archive time.

Notes

  • Storage follows the change's design: LaunchPad keeps its own tables (launchpad_catalogue_apps, launchpad_app_requests) and consumes OpenRegister only at runtime.
  • appinfo/info.xml version bumped so the migration runs.

Tests

  • Added: CatalogueServiceTest (11), CatalogueControllerTest (9), 2 in NotifierTest, 1 in DemoShowcasesServiceTest, 2 mapper-query golden cases, WidgetPickerModal.catalogue.spec.js (10).
  • PHPUnit: before 4062 tests (0 failures, 13 skipped); after 4087 tests (0 failures, 13 skipped).
  • Vitest: 2218 tests after, all passing (the props golden gained the two new picker props).
  • phpcs (no errors) and phpstan (no errors) on the touched lib files; eslint (no errors) on the touched JS/Vue.

Generated by Claude Code

An app catalogue of approved applications: administrators keep entries
(name, description, icon, address, target groups) through
/api/admin/catalogue; GET /api/catalogue returns only the entries the
caller's groups may see, and the add flow lists them under "From the app
catalogue", where one click places an ordinary tile. "Can't find your
app?" sends a request (at most 10 open per user) that notifies every
administrator and the optional catalogue manager group; approving adds
the entry and declining needs a note, and either notifies the requester.
A showcase install seeds four demo entries into an empty catalogue.

Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde added a commit that referenced this pull request Nov 14, 2026
…n [skip ci]

#1212 adds lib/Migration/Version002013Date20261114090000.php for the app
catalogue and this branch added a different migration under the same class
name, with the same app version. Whichever landed second would collide, and
on an instance already at that version its migration would never run. This
branch's migration becomes Version002014Date20261114100000 and the app
version 1.1.7-unstable.20261114100000.

Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde added a commit that referenced this pull request Nov 14, 2026
…lings [skip ci]

The branch set 1.1.7-unstable.20261114000000, below the
1.1.7-unstable.20261114090000 that #1212 sets. Landing after it would
move the app version backwards, which Nextcloud refuses, and the
announcements migration would not run. 1.1.7-unstable.20261114110000 is
above every open launchpad build.

Assisted-by: ClaudeCode:claude-opus-5-5
Both sides added Version002013Date20261114090000: development's keeps that
name, the app catalogue tables move to Version002015Date20261114130000 with
an app version bump so the step runs.

Assisted-by: ClaudeCode:claude-opus-5-5
Admin App catalogue tab: entries with group picker, open requests with
approve (prefilled form) and decline (required note), manager group.

Assisted-by: ClaudeCode:claude-opus-5-5
App catalogue strings in en and all 36 required locales: the picker's
catalogue section and request form, the admin tab, and the notifier's
app_requested and app_request_decided copy. tile-catalogue is built in
the parity matrix with evidence lines; the props golden records the
new tab's groups prop.

Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde added a commit that referenced this pull request Nov 14, 2026
#1212 adds "Nextcloud app" and "Web address" to en.js and nl.js with the
same Dutch values; this branch added them to nl.js too, so the tree with
both carried each key twice and l10nNoDuplicateKeys failed.

Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde and others added 11 commits November 15, 2026 00:30
Kept both sides: the app catalogue strings and development's admin tour
and office tile strings in every locale, and both the catalogue and the
office tile pack in the widget picker, Views and the API client.

Assisted-by: ClaudeCode:claude-opus-5-5
Keeps both sides: the app catalogue and announcement notifications, l10n
keys and mapper goldens (re-recorded); the newer info.xml version; and marks
the nine catalogue operations internal in openapi.json for the stability
test development added.

Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Resolves the conflicts with development, keeping both sides:
- l10n nl.js / nl.json: the app catalogue strings of this branch; the tile
  sorting strings development already carries elsewhere are kept once.
- AdminSettings: development's Search shortcuts tab, then the App catalogue
  tab; the tabs spec lists both.

Unit suite: 4564 tests, no failures. vitest: 2672 passed. l10n parity and
schema-l10n report the same gaps as development (inherited).

Assisted-by: ClaudeCode:claude-opus-5-5
Keeps both admin tabs (app catalogue and communities) and both sets of
strings; info.xml takes development's version.

Assisted-by: ClaudeCode:claude-opus-5-5
… tag closeRequestForm [skip ci]

Assisted-by: ClaudeCode:claude-opus-5-5
…[skip ci]

LaunchPadAdmin is the class every administrator endpoint's authorization
attribute names; its initial-state assembly moves to AdminFormState so the
heavily-depended-on class stays small. Same initial state, same template.

Assisted-by: ClaudeCode:claude-opus-5-5
…ip ci]

The nine catalogue operations used a tag the document's global tags did
not define (API Design Rules operation-tag-defined).

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 6a7f9e5 into development Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants