Repository navigation
feat(launchpad): build launcher-app-catalogue - #1212
Merged
Merged
Conversation
An app catalogue of approved applications: administrators keep entries (name, description, icon, address, target groups) through /api/admin/catalogue; GET /api/catalogue returns only the entries the caller's groups may see, and the add flow lists them under "From the app catalogue", where one click places an ordinary tile. "Can't find your app?" sends a request (at most 10 open per user) that notifies every administrator and the optional catalogue manager group; approving adds the entry and declining needs a note, and either notifies the requester. A showcase install seeds four demo entries into an empty catalogue. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 14, 2026 08:35
rubenvdlinde
added a commit
that referenced
this pull request
Nov 14, 2026
…n [skip ci] #1212 adds lib/Migration/Version002013Date20261114090000.php for the app catalogue and this branch added a different migration under the same class name, with the same app version. Whichever landed second would collide, and on an instance already at that version its migration would never run. This branch's migration becomes Version002014Date20261114100000 and the app version 1.1.7-unstable.20261114100000. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
added a commit
that referenced
this pull request
Nov 14, 2026
…lings [skip ci] The branch set 1.1.7-unstable.20261114000000, below the 1.1.7-unstable.20261114090000 that #1212 sets. Landing after it would move the app version backwards, which Nextcloud refuses, and the announcements migration would not run. 1.1.7-unstable.20261114110000 is above every open launchpad build. Assisted-by: ClaudeCode:claude-opus-5-5
Both sides added Version002013Date20261114090000: development's keeps that name, the app catalogue tables move to Version002015Date20261114130000 with an app version bump so the step runs. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Admin App catalogue tab: entries with group picker, open requests with approve (prefilled form) and decline (required note), manager group. Assisted-by: ClaudeCode:claude-opus-5-5
App catalogue strings in en and all 36 required locales: the picker's catalogue section and request form, the admin tab, and the notifier's app_requested and app_request_decided copy. tile-catalogue is built in the parity matrix with evidence lines; the props golden records the new tab's groups prop. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
added a commit
that referenced
this pull request
Nov 14, 2026
#1212 adds "Nextcloud app" and "Web address" to en.js and nl.js with the same Dutch values; this branch added them to nl.js too, so the tree with both carried each key twice and l10nNoDuplicateKeys failed. Assisted-by: ClaudeCode:claude-opus-5-5
Kept both sides: the app catalogue strings and development's admin tour and office tile strings in every locale, and both the catalogue and the office tile pack in the widget picker, Views and the API client. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Keeps both sides: the app catalogue and announcement notifications, l10n keys and mapper goldens (re-recorded); the newer info.xml version; and marks the nine catalogue operations internal in openapi.json for the stability test development added. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Resolves the conflicts with development, keeping both sides: - l10n nl.js / nl.json: the app catalogue strings of this branch; the tile sorting strings development already carries elsewhere are kept once. - AdminSettings: development's Search shortcuts tab, then the App catalogue tab; the tabs spec lists both. Unit suite: 4564 tests, no failures. vitest: 2672 passed. l10n parity and schema-l10n report the same gaps as development (inherited). Assisted-by: ClaudeCode:claude-opus-5-5
Keeps both admin tabs (app catalogue and communities) and both sets of strings; info.xml takes development's version. Assisted-by: ClaudeCode:claude-opus-5-5
… tag closeRequestForm [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…[skip ci] LaunchPadAdmin is the class every administrator endpoint's authorization attribute names; its initial-state assembly moves to AdminFormState so the heavily-depended-on class stays small. Same initial state, same template. Assisted-by: ClaudeCode:claude-opus-5-5
…ip ci] The nine catalogue operations used a tag the document's global tags did not define (API Design Rules operation-tag-defined). Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds openspec change
launcher-app-catalogue(REQ-ACAT-001..004), partly: the backend, the add-flow section and the request form. The admin section and the locale strings follow.Tasks done
catalogue.listandcatalogue.request(["admin", "@all"]),catalogue.manageandcatalogue.decide(["admin"]) inlib/actions.seed.json, each wired torequireAction(); the action baseline test lists them.CatalogueService: group-filtered list (throughAdminTemplateService::getUserGroupIdsFor, the one place allowed to read groups), create/update/delete with validation (http(s) address or Nextcloud app id), request with the 10-open limit, approve (prefills the requested name, links the request to the new entry) and decline (note required).CatalogueController(GET /api/catalogue,POST /api/catalogue/requests, 429 with coderequest_limit) andAdminCatalogueController(CRUD, approve, decline, manager group), every admin method#[AuthorizedAdminSetting(LaunchPadAdmin::class)]plus an admin check and its action. Routes andopenapi.jsonentries added.Notifierrendersapp_requested(to every administrator and the members of the optionalcatalogue_manager_group) andapp_request_decided(approved, or declined with the note), linking to the admin section and to LaunchPad.WidgetPickerModal, above the widget list and filtered by the same search box; one click places an ordinary tile through the existing tile path (tileFromCatalogueApp).CatalogueService::seedDemoEntries()(Zaaksysteem, Personeelsportaal, Bestanden, Agenda, for everyone) runs on a showcase install when the catalogue is empty; a failure is logged and does not undo the install.Done in code, left unchecked
Version002013Date20261114090000with both tables, entities and mappers (mapper query golden recorded). Open: running it on PostgreSQL and MySQL, which needs live databases.Left
Notes
launchpad_catalogue_apps,launchpad_app_requests) and consumes OpenRegister only at runtime.appinfo/info.xmlversion bumped so the migration runs.Tests
CatalogueServiceTest(11),CatalogueControllerTest(9), 2 inNotifierTest, 1 inDemoShowcasesServiceTest, 2 mapper-query golden cases,WidgetPickerModal.catalogue.spec.js(10).Generated by Claude Code