Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openspec/changes/extension-passkey-enrolment/tasks.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Nothing here starts before Ruben approved the design. Each decision in design.md

## 2. Extension

- [x] 2.1 Pairing through Login Flow v2 with the manual app password fallback and the file access note (D3). Verify: `tests/extension/pairing.spec.js` (flow success, closed tab, 20 minute timeout, verified before stored).
- [x] 2.1 Pairing through Login Flow v2 with the manual app password fallback and the file access note (D3). Verify: the extension keeps its tests beside the code, so this is `browser-extension/src/accounts/login-flow.test.ts` (flow success: `polls until the user signed in`; closed tab: `stops without credentials when the login tab is closed`; `stops after 20 minutes`) and `browser-extension/src/background/router.test.ts` (verified before stored: `opens the login page and adds the account it verified, with the file access notice`, `stores nothing and deletes the app password when it does not verify`). No file `tests/extension/pairing.spec.js` was ever written.
- The tests sit next to the code, as the extension's convention is: `src/accounts/login-flow.test.ts` (flow, closed tab, 20 minute timeout, foreign poll origin) and `src/background/router.test.ts` (verified before stored, an app password that does not verify is deleted again). The file access note shows on the unlock screen until the first unlock.
- [x] 2.2 Enrolment in an extension tab: server options, `create()` and proof `get()` with the server host as relying party, random user handle, `residentKey` `discouraged`, PRF wrap, post (D1). Verify: vitest for the request shape, including that no master password, raw unlock key or PRF output is sent.
- Built in keepiq#1644 (`src/vault/passkey-unlock.ts`, `src/vault/passkey-api.ts`) and the window in `entrypoints/popup/views/VaultPasskeyWindow.tsx`, opened from Settings, Account security. The ceremony runs in an extension popup window. The tests run over a software authenticator; a real browser ceremony is task 0.3.
Expand Down