Skip to content

feat(keepiq): build extension-passkey-enrolment - #1898

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-extension-passkey-enrolment-b2
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-extension-passkey-enrolment-b2

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Round 2 of openspec/changes/extension-passkey-enrolment. The earlier pass said "already built", but the change still has unticked tasks, so this pass checked each one.

Tasks done

  • Task 2.1 named tests/extension/pairing.spec.js as its verification. That file was never written, in this repo or on any branch. Its four cases are already tested where the extension keeps its tests, beside the code:
    • browser-extension/src/accounts/login-flow.test.ts covers flow success, the closed tab and the 20-minute timeout.
    • browser-extension/src/background/router.test.ts covers "verified before stored": the account is added only once verified, and nothing is stored (the app password is deleted) when verification fails.
  • The task now names those files and test names, so the next pass does not go looking for a missing spec. Both files pass: 45 tests.

Tasks left, and why

  • 0.2: needs the published store listing ids and a real Firefox 150 ceremony.
  • 0.3: needs Chrome 122+ and Firefox 150+ with a paired server.
  • 4.2: manual live test by a person.
  • 4.1: the pre-push check of the build itself.

Tests: no code changed. The two named test files run green (45 passed).
Suite before/after: unchanged. This PR only edits tasks.md.


Generated by Claude Code

Task 2.1 named tests/extension/pairing.spec.js as its verification, a
file that was never written. Its four cases are covered by the tests
the extension keeps beside the code, login-flow.test.ts and
router.test.ts (45 passing); point the task at those.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant