Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lib/Lifecycle/MeetingTransitionGuard.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Meeting Transition Guard
*
* Guards the meeting lifecycle's open transition by reading the declaratively
* computed quorumMet field instead of invoking QuorumService.
* computed quorumMet field from the Meeting schema.
*
* @category Lifecycle
* @package OCA\Decidesk\Lifecycle
Expand All @@ -15,7 +15,7 @@
*
* @link https://conduction.nl
*
* @spec openspec/changes/spec/tasks.md#task-1
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-1
*
* SPDX-FileCopyrightText: 2026 Conduction B.V. <info@conduction.nl>
* SPDX-License-Identifier: EUPL-1.2
Expand All @@ -28,11 +28,10 @@
/**
* Guard for meeting lifecycle transitions.
*
* Chain spec 2 of 3: reads quorumMet from the declarative Meeting schema
* (computed by x-openregister-calculations in chain spec 1) rather than
* calling QuorumService.
* Reads quorumMet from the declarative Meeting schema
* (computed by x-openregister-calculations).
*
* @spec openspec/changes/spec/tasks.md#task-1
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-1
*/
class MeetingTransitionGuard
{
Expand All @@ -46,7 +45,7 @@ class MeetingTransitionGuard
*
* @param array<string, mixed> $meeting Meeting object array (already loaded by the caller)
*
* @spec openspec/changes/spec/tasks.md#task-1
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-1
*
* @return bool True when quorum is met or no quorum is required, false otherwise
*/
Expand Down
168 changes: 0 additions & 168 deletions lib/Service/QuorumService.php

This file was deleted.

61 changes: 0 additions & 61 deletions task-audit.json

This file was deleted.

14 changes: 7 additions & 7 deletions tests/Unit/Lifecycle/MeetingTransitionGuardTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @link https://conduction.nl
*
* @spec openspec/changes/spec/tasks.md#task-4
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-4
*
* SPDX-FileCopyrightText: 2026 Conduction B.V. <info@conduction.nl>
* SPDX-License-Identifier: EUPL-1.2
Expand All @@ -29,9 +29,9 @@
* Tests for MeetingTransitionGuard.isOpenAllowed.
*
* Verifies that the guard reads the declarative quorumMet field
* rather than calling QuorumService.
* from the Meeting schema (computed by x-openregister-calculations).
*
* @spec openspec/changes/spec/tasks.md#task-4
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-4
*/
class MeetingTransitionGuardTest extends TestCase
{
Expand All @@ -58,7 +58,7 @@ protected function setUp(): void
/**
* Meeting with quorumMet = true allows the open transition.
*
* @spec openspec/changes/spec/tasks.md#task-4
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-4
*
* @return void
*/
Expand All @@ -78,7 +78,7 @@ public function testOpenAllowedWhenQuorumMet(): void
/**
* Meeting with quorumMet = false blocks the open transition.
*
* @spec openspec/changes/spec/tasks.md#task-4
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-4
*
* @return void
*/
Expand All @@ -101,7 +101,7 @@ public function testOpenBlockedWhenQuorumNotMet(): void
* When no quorum rule is configured, the x-openregister-calculations
* expression sets quorumMet = true. The guard honours that signal.
*
* @spec openspec/changes/spec/tasks.md#task-4
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-4
*
* @return void
*/
Expand All @@ -121,7 +121,7 @@ public function testOpenAllowedWhenNoQuorumRequired(): void
/**
* Meeting without quorumMet key defaults to false (safe default).
*
* @spec openspec/changes/spec/tasks.md#task-4
* @spec openspec/changes/archive/2026-05-11-quorum-guard-rewrite/tasks.md#task-4
*
* @return void
*/
Expand Down
Loading
Loading