Skip to content

feat(spec): implement spec (#159) - #164

Merged
rubenvdlinde merged 1 commit into
developmentfrom
feature/159/spec
May 25, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
feature/159/spec

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Closes #159

Summary

Auto-generated draft PR for OpenSpec change spec.
The Hydra builder ran the spec but could not run gh pr create itself
(Phase D+E credential strip — Claude has no GH_TOKEN by design).
The entrypoint detected commits on the feature branch with no PR and
created this draft so the reviewer + security + applier can proceed.

Spec Reference

Commits on this branch

Files changed

  • lib/Lifecycle/MeetingTransitionGuard.php
  • lib/Service/QuorumService.php
  • openspec/changes/spec/design.md
  • openspec/changes/spec/proposal.md
  • openspec/changes/spec/tasks.md
  • package-lock.json
  • package.json
  • task-audit.json
  • tests/Unit/Lifecycle/MeetingTransitionGuardTest.php
  • tests/Unit/Service/QuorumServiceTest.php

PR auto-created by Hydra builder entrypoint (hydra_ensure_pr_exists)
because Claude's session closed without running gh pr create.
Reviewer + applier follow as normal.

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidesk @ 26f9cdf

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ❌
composer ✅ ✅ 100/100
npm ❌ ❌
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️

Quality workflow — 2026-05-10 11:31 UTC

Download the full PDF report from the workflow artifacts.

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidesk @ ca52f44

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
composer ✅ ✅ 100/100
npm ✅ ✅ 474/474
PHPUnit ✅
Newman ✅
Playwright ⏭️

Coverage: 0% (0/115 statements)


Quality workflow — 2026-05-19 03:24 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde marked this pull request as ready for review May 25, 2026 16:06
@rubenvdlinde
rubenvdlinde merged commit 1e8ee54 into development May 25, 2026
46 checks passed
@rubenvdlinde
rubenvdlinde deleted the feature/159/spec branch May 25, 2026 16:06
@rubenvdlinde
rubenvdlinde restored the feature/159/spec branch May 28, 2026 21:56
rubenvdlinde added a commit that referenced this pull request Aug 5, 2026
…failing CI (#412)

v1.0.1 is `f4d9756` (2026-08-03) and predates three gate fixes, so every
Hydra Gates run this repo has ever made executed a script in which 16
gates reported PASS when their helper never ran (ConductionNL/.github#147),
gate-33 had no axe report to read and never said so (#148), and gates 6
and 7 reported PASS on an empty scope (#149). The tick was identical
either way, which is why nothing in this repo's history shows it.

That pin is now also RED, and the mechanism is worth writing down.
quality.yml is referenced `@main` while this package is PINNED, so the
two can desync. #164 flipped `hydra-gates-require-full-coverage` to
default true in the shared workflow, and that flag requires a gate to
DECLARE itself not-applicable. v1.0.1 contains ZERO `_skip` calls; v1.3.0
has 36. v1.0.1 has no vocabulary to declare, so every absent prerequisite
became "DID NOT RUN" and failed the job — for gates the repo has no
subject matter for.

Measured on this branch, diff-scoped against origin/development exactly
as CI scopes it, in a private mount namespace with a private tmpfs (the
runner's ~50 /tmp/hydra-gate-*.log paths are shared state and two
concurrent runs corrupt each other's counts, .github#158 item 6):

  v1.0.1  exit 98  FAIL — "GATES THAT DID NOT RUN: 24 33"
  v1.3.0  exit 0   PASS — those gates named NOT APPLICABLE, with reasons

Independently confirmed end-to-end: doriath#160 changed this one line and
nothing else, and its Hydra Gates job went failure -> success.

v1.3.0 is `f7eaf2a` = .github@main at the time it was cut.

Refs ConductionNL/.github#159
@rubenvdlinde
rubenvdlinde deleted the feature/159/spec branch August 14, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants