Repository navigation
fix(gates): gate-111 is registered twice on main, drop the copy I added - #710
Merged
Merged
Conversation
#706 and #700 fixed the same defect, and both landed. The sequence: at 29c827e gate-111 was unregistered, which is what I measured and what #706 was written against. #700 then merged 50ee1ff, "wire gate-111 into the runner so it emits a verdict", which fixed it. #706 merged on top and added a second block. I did not re-check between opening the PR and merging it, and that is the whole cause. Two blocks reporting one gate number is the exact failure check_gate_numbers_ unique.sh exists to prevent: one verdict overwrites the other in the report, and the COVERAGE tally counts one slot for two gates, so a gate that never ran is indistinguishable from one that passed. (The uniqueness check reads `_pass|_fail|_skip <n>` occurrences rather than block headers, so it counted 91 gates and stayed green over the duplicate.) This removes MY block and keeps 50ee1ff's, which landed first and is the better of the two: it routes the crash check through the shared `_helper_finished` helper rather than open-coding the grep. A pure deletion -- 65 lines removed, zero added. Verified: gate-111 registered once, `check_gate_numbers_unique.sh` reports 91 gates every number claimed once, `bash -n` clean, and `test_gate_acceptance_matrix.sh` stays at 244 passed / 0 failed with gate-111 still FAILing on planted/ naming PlantedNode and PASSing on clean/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
#706 and #700 fixed the same defect, and both landed.
29c827e250ee1ffe(via #700)f01d57f3(#706)I did not re-check between opening #706 and merging it. That is the whole cause.
Why it matters
Two blocks reporting one gate number is the exact failure
check_gate_numbers_unique.shexists to prevent: one verdict overwrites the other in the report, and the COVERAGE tally counts one slot for two gates, so a gate that never ran becomes indistinguishable from one that passed.Worth noting the guard did not catch this: it reads
_pass|_fail|_skip <n>occurrences rather than block headers, so it counted 91 gates and stayed green over a duplicate block.What this does
Removes my block and keeps
50ee1ffe's. Theirs landed first and is the better of the two: it routes the crash check through the shared_helper_finishedhelper rather than open-coding the grep.A pure deletion. 65 lines removed, zero added.
Verification
check_gate_numbers_unique.sh: 91 gates, every number claimed once.bash -nclean.test_gate_acceptance_matrix.sh: 244 passed / 0 failed, with gate-111 still FAILing onplanted/namingPlantedNodeand PASSing onclean/.🤖 Generated with Claude Code