Skip to content

fix(gates): gate-111 is registered twice on main, drop the copy I added - #710

Merged
rubenvdlinde merged 1 commit into
mainfrom
fix/gate-111-registered-twice
Sep 8, 2026
Merged

rubenvdlinde merged 1 commit into
mainfrom
fix/gate-111-registered-twice

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What happened

#706 and #700 fixed the same defect, and both landed.

commit
29c827e2 gate-111 unregistered. This is what I measured, and what #706 was written against.
50ee1ffe (via #700) "wire gate-111 into the runner so it emits a verdict" — fixed it.
f01d57f3 (#706) merged on top and added a second block.

I did not re-check between opening #706 and merging it. That is the whole cause.

Why it matters

Two blocks reporting one gate number is the exact failure check_gate_numbers_unique.sh exists to prevent: one verdict overwrites the other in the report, and the COVERAGE tally counts one slot for two gates, so a gate that never ran becomes indistinguishable from one that passed.

Worth noting the guard did not catch this: it reads _pass|_fail|_skip <n> occurrences rather than block headers, so it counted 91 gates and stayed green over a duplicate block.

What this does

Removes my block and keeps 50ee1ffe's. Theirs landed first and is the better of the two: it routes the crash check through the shared _helper_finished helper rather than open-coding the grep.

A pure deletion. 65 lines removed, zero added.

Verification

  • gate-111 registered once.
  • check_gate_numbers_unique.sh: 91 gates, every number claimed once.
  • bash -n clean.
  • test_gate_acceptance_matrix.sh: 244 passed / 0 failed, with gate-111 still FAILing on planted/ naming PlantedNode and PASSing on clean/.

🤖 Generated with Claude Code

#706 and #700 fixed the same defect, and both landed.

The sequence: at 29c827e gate-111 was unregistered, which is what I measured
and what #706 was written against. #700 then merged 50ee1ff, "wire gate-111
into the runner so it emits a verdict", which fixed it. #706 merged on top and
added a second block. I did not re-check between opening the PR and merging
it, and that is the whole cause.

Two blocks reporting one gate number is the exact failure check_gate_numbers_
unique.sh exists to prevent: one verdict overwrites the other in the report,
and the COVERAGE tally counts one slot for two gates, so a gate that never ran
is indistinguishable from one that passed. (The uniqueness check reads
`_pass|_fail|_skip <n>` occurrences rather than block headers, so it counted
91 gates and stayed green over the duplicate.)

This removes MY block and keeps 50ee1ff's, which landed first and is the
better of the two: it routes the crash check through the shared
`_helper_finished` helper rather than open-coding the grep.

A pure deletion -- 65 lines removed, zero added.

Verified: gate-111 registered once, `check_gate_numbers_unique.sh` reports 91
gates every number claimed once, `bash -n` clean, and
`test_gate_acceptance_matrix.sh` stays at 244 passed / 0 failed with gate-111
still FAILing on planted/ naming PlantedNode and PASSing on clean/.
@rubenvdlinde
rubenvdlinde merged commit 4778caa into main Sep 8, 2026
40 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/gate-111-registered-twice branch September 8, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant