Skip to content

fix(gates): register gate-111, which shipped complete except for being called - #706

Merged
rubenvdlinde merged 1 commit into
mainfrom
fix/gate-111-was-never-registered
Sep 8, 2026
Merged

rubenvdlinde merged 1 commit into
mainfrom
fix/gate-111-was-never-registered

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

The blocker

Package invariants is a required status check on main, and it is red on main today. It has been red since #698 merged, so every pull request to this repository is blocked by it. This PR is one of the two causes.

#698 landed gate-111 (flow-node-taxonomy) with its checker, its acceptance fixtures, its expect.conf row and its own test suite. Nothing ever called it.

FAIL — [flow-node-taxonomy/planted] gate-111 emitted NO verdict line at all
       — a gate that says nothing is not a pass
FAIL — [flow-node-taxonomy/clean]   gate-111 emitted NO verdict line at all

The checker was never broken

Run against its own fixtures it already answered correctly, and still does:

tree rc result
planted 1 1 finding, names PlantedNode
clean 0 pass
no-nodes 4 NOT APPLICABLE

This PR adds the runner block those return codes were written for. No checker change.

Two deliberate choices in the block

Scoped by path, never by interface. The prerequisite is [ -d lib/Service/Flow/Nodes ]. That is #698's own design note: on a measured instance 38 of 65 step types come from apps in other repositories on their own release cycles, and an interface-scoped gate would fire on all 38 inside pull requests that cannot fix them.

The terminal summary is asserted before the exit code is believed. The checker states in its own source that checked N flow node file(s) is how the runner distinguishes a clean run from a crashed one. A missing summary now reports a wiring skip, not a pass.

Verification

  • test_gate_acceptance_matrix.sh: 2 failures to 244 passed / 0 failed, exit 0.
  • test_gate111_flow_node_taxonomy.sh: all cases behaved.
  • check_gate_numbers_unique.sh: 91 gates, every number claimed once.
  • bash -n on the runner.

The other cause is #707.

🤖 Generated with Claude Code

…g called

#698 landed gate-111 (flow-node-taxonomy) with its checker, its acceptance
fixtures, its expect.conf row and its own test suite. Nothing ever called it.

So it emitted no verdict in any repository, and the acceptance matrix failed
with the only sentence that fits:

    FAIL — [flow-node-taxonomy/planted] gate-111 emitted NO verdict line at
           all — a gate that says nothing is not a pass

That failure fails `test_gate_acceptance_matrix.sh`, which fails the `Package
invariants` job, which is a REQUIRED status check on main. An unregistered
gate has therefore been blocking every pull request to this repository since
#698 merged.

The checker itself was never broken. Run against its own fixtures it already
answered correctly, and still does:

    planted   rc=1, 1 finding, names PlantedNode
    clean     rc=0
    no-nodes  rc=4, NOT APPLICABLE

This adds the runner block those return codes were written for.

TWO THINGS THE BLOCK DOES DELIBERATELY.

Scoped by PATH (`[ -d lib/Service/Flow/Nodes ]`), never by interface. That is
#698's own design note: on a measured instance 38 of 65 step types come from
apps in other repositories on their own release cycles, and an
interface-scoped gate would fire on all 38 inside pull requests that cannot
fix them.

The terminal summary is asserted BEFORE the exit code is believed. The checker
says in its own source that `checked N flow node file(s)` is how the runner
tells a clean run from a crashed one, so a missing summary reports a wiring
skip rather than a pass.

Verified: `test_gate_acceptance_matrix.sh` goes from 2 failures to
244 passed / 0 failed, and gate-111 now reports FAIL on planted/ naming
PlantedNode, PASS on clean/, and NOT APPLICABLE on no-nodes/.
@rubenvdlinde
rubenvdlinde merged commit f01d57f into main Sep 8, 2026
40 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/gate-111-was-never-registered branch September 8, 2026 10:12
rubenvdlinde added a commit that referenced this pull request Sep 8, 2026
…ed (#710)

#706 and #700 fixed the same defect, and both landed.

The sequence: at 29c827e gate-111 was unregistered, which is what I measured
and what #706 was written against. #700 then merged 50ee1ff, "wire gate-111
into the runner so it emits a verdict", which fixed it. #706 merged on top and
added a second block. I did not re-check between opening the PR and merging
it, and that is the whole cause.

Two blocks reporting one gate number is the exact failure check_gate_numbers_
unique.sh exists to prevent: one verdict overwrites the other in the report,
and the COVERAGE tally counts one slot for two gates, so a gate that never ran
is indistinguishable from one that passed. (The uniqueness check reads
`_pass|_fail|_skip <n>` occurrences rather than block headers, so it counted
91 gates and stayed green over the duplicate.)

This removes MY block and keeps 50ee1ff's, which landed first and is the
better of the two: it routes the crash check through the shared
`_helper_finished` helper rather than open-coding the grep.

A pure deletion -- 65 lines removed, zero added.

Verified: gate-111 registered once, `check_gate_numbers_unique.sh` reports 91
gates every number claimed once, `bash -n` clean, and
`test_gate_acceptance_matrix.sh` stays at 244 passed / 0 failed with gate-111
still FAILing on planted/ naming PlantedNode and PASSing on clean/.

Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant