Repository navigation
feat(lagekarte): place Bereitstellungsräume from the Organisation on the map - #991
Open
DeepDiver1975 wants to merge 1 commit into
Open
DeepDiver1975 wants to merge 1 commit into
DeepDiver1975 wants to merge 1 commit into
Conversation
…the map A Bereitstellungsraum recorded in the Organisation tab can now be put on the Lagekarte. The map stores only where it stands (CommandNode.Position and LabelOffset); its name comes from the node on every refresh, so a rename in the Organisation renames the sign, and a tap on the pin, the sign or the pencil in the side list opens the Organisation's own CommandNodeDialog for it. A dissolved node drops off the map. - Domain: Incident.PlaceCommandNode / MoveCommandNodeLabel, only for a live Bereitstellung, with an ETB line on placing and removing. - Persistence: migration V46 adds command_nodes.position_lat/lon and label_dx/dy, declared in SchemaGuard; repository and snapshot carry them. - Sync: placeCommandNode and moveCommandNodeLabel; a host at 43 cannot read them, so ProtocolVersion and MinimumProtocolVersion rise to 44. - Lagekarte: a BEREITSTELLUNGSRÄUME group in the side list (place, edit, show, remove with confirmation) and a red "Stelle" circle marked BR. Fixes #966 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Bereitstellungsraum recorded in the Organisation tab can now be placed on the Lagekarte, and the two stay one record. The map stores only where the Raum stands. Its name and details come from the Organisation node on every refresh, so a rename there renames the sign at once. A tap on its pin or sign, or the pencil beside it in the side list, opens the same
CommandNodeDialogthe Organisation uses, so the details are edited in one place. A dissolved Bereitstellungsraum leaves the map.Fixes #966
What changed
CommandNodegetsPositionandLabelOffset.Incident.PlaceCommandNodeaccepts only a live Bereitstellung; any other kind is refused with "Nur ein Bereitstellungsraum steht auf der Lagekarte.". The ETB records when one is placed ("Bereitstellungsraum X auf der Lagekarte eingetragen") and when it is taken off ("… von der Lagekarte genommen"); a move writes nothing, as for units.Incident.MoveCommandNodeLabelmoves the sign beside its pin and writes no ETB line.CommandNodeRepairkeeps both fields when it repairs a node on reading.command_nodes.position_lat,position_lon,label_dxandlabel_dy(REAL, as onforce_units). They are declared inSchemaGuard.ExpectedColumnsand saved and loaded by the repository. A garbled value from a hostile file costs only the mark.placeCommandNodeandmoveCommandNodeLabel, and the snapshot's command nodes carry position and offset. A host at 43 cannot read the new commands, soProtocolVersionandMinimumProtocolVersionboth rise to 44. The floor assertions of the 41–43 handshake tests are loosened from "≤ 40" to "≥ 40".MapOverlaysViewModel.ConfirmRemove, built without depending on fix(lagekarte): confirm before taking a Fahrzeug off the map #984.TacticalSignControl.IsBereitstellungsraumdraws the DV 102 Grundzeichen "Stelle, Einrichtung", a red circle, marked "BR", anchored and tied back to its pin by a Verbindungsstrich like the vehicle signs.This PR takes migration V46 and protocol 44 with floor 44. PR #990 (#973) also takes V46 and protocol 44 with floor 44, and PR #988 takes protocol 44. Whichever of these lands first, this PR must be rebased and renumbered above it: the migration,
SyncProtocoland its history entry, and the exact-value test inVersionHandshakeTests.Please check
DrawStelle).Screenshots
Lagekarte at z16 on the installed FFB Kartenpaket (OSM, DGM5), Hydranten off for readability. Units and names are fictional.
Before (origin/main): a vehicle had to stand in for the Bereitstellungsraum.

After: BR Süd from the Organisation, with its Standort and Rufname in the list; BR Nord is not placed yet.

Test evidence
make clean ci: every assembly passed — Acceptance 3237, AppLogic 1211, Persistence 858, Domain 1133, Sync 334, App 141, Documents 72, Osm 27. Sync.Hosting hit the known machine-wide "inotify instances (128)" limit (114 failures). Rerun alone withDOTNET_USE_POLLING_FILE_WATCHER=true: 264 of 264 passed.Lagekarte127 passed, DomainBereitstellungsraum13 passed.make format-check: clean.make codeql: 0 results on changed lines (onecs/useless-assignment-to-localin a test was fixed before push).make mutate SINCE=origin/main BREAK=80, changed lines: Domain 100 % (19/19), Persistence 100 % (31/31), Sync 100 % (2/2), AppLogic 100 % (53/53).🤖 Generated with Claude Code