Repository navigation
feat(aufgaben): set the time until the reminder directly - #988
Open
DeepDiver1975 wants to merge 2 commits into
Open
DeepDiver1975 wants to merge 2 commits into
DeepDiver1975 wants to merge 2 commits into
Conversation
The Aufgabe edit panel takes the minutes until the reminder in a box next to "+5 MIN" and applies them with SETZEN (or Enter, or SPEICHERN when the box was changed). The new time replaces the old one, shorter or longer, and also gives a timer to an Aufgabe that had none. The box opens on the minutes left, rounded up. - Domain: IncidentTask.WithTimer and Incident.SetTaskTimer, 1 to 1440 minutes counted from now; a done Aufgabe refuses. - Sync: SetTaskTimerCommand carries minutes, so the host stamps the due time with its own clock. A host at 43 does not know the command, so ProtocolVersion and MinimumProtocolVersion both rise to 44. - TaskRow.HasTimer follows the task, so +5 MIN turns on once SETZEN has given a task its first timer. Fixes #964 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Kills the surviving mutants the diff mutation run found on the new SetTaskTimer lines: the one-minute and cap boundaries, the exactly-due prefill, and the German refusal messages a joined client reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The time until an Aufgabe's reminder can now be typed straight into the edit panel. Before, it could only be moved with "+5 MIN": moving it by 30 minutes took six clicks, and it could not be shortened at all.
Fixes #964
What changed
TasksView.axaml): the TIMER (MIN) field now has a minutes box and a SETZEN button between the countdown and "+5 MIN", which stays. The box opens on the minutes left, rounded up. It is empty when the Aufgabe has no timer or the timer has run out. SETZEN or Enter in the box applies the time at once and keeps the panel open, as +5 MIN does. If the box was changed, SPEICHERN applies the time too, so a typed time is never lost when the panel closes. An empty or out-of-range value shows "Minuten bis zur Erinnerung eintragen (1 bis 1440)" in the panel's error line and changes nothing. I replaced the old comment that said the timer was deliberately not a field.IncidentTask.WithTimer(minutesFromNow, now)andIncident.SetTaskTimer(taskId, minutes, clock). The due time becomes now + minutes, which can be shorter or longer than before, and an Aufgabe without a timer gets one. A done Aufgabe throws. Minutes outside 1..IncidentTask.MaxTimerMinutes(1440, one day) throw with a German message, which a joined client shows as the host's reason. The TIMER field used when creating an Aufgabe has no upper cap, so this cap is new and applies only to setting the time. LikeExtendTaskTimer, this writes no ETB line. The due alarm needs no reset:TasksViewModeldrops a task from its announced set as soon as it is no longer overdue, so it sounds again when the new time is reached.SetTaskTimerCommand(TaskId, Minutes)(setTaskTimer) sends minutes, not an absolute time, so the host stamps the due time with its own clock. It is wired through the[JsonDerivedType]allowlist,CommandApplier,IIncidentSession,LocalIncidentSessionandRemoteIncidentSession.ProtocolVersionandMinimumProtocolVersionboth rise to 44.LegacyProtocolVersion(1) stays below the floor. The pins for 41–43 inVersionHandshakeTestsasserted a floor of 40, so they now only assert floor ≤ protocol, which is how the older "not the floor" pins are written. If another PR takes protocol 44 first, renumber this one above main before merging.TaskRow.HasTimeris now observable and refreshed inUpdate, so "+5 MIN" turns on once SETZEN has given a timerless Aufgabe its first timer.Screenshots
Before:
After (desktop, and the shared view at phone width):
Tests
WorkspaceCollaborationTests: a client sets 30 min and host and client both converge on the host's clock + 30.TaskEditingTests): prefill rounded up, empty prefill without a timer or when overdue, SETZEN shorter and longer, a timerless task gets one, validation message, SPEICHERN applies a typed time, SPEICHERN leaves an untouched box alone, invalid typed minutes keep the panel open, +5 MIN updates the box.EditTimerBoxsets the reminder ("noch 30:00") and keeps the panel open.Evidence
make clean ci: 0 warnings, 0 errors, noTest Run Failed; every assembly passed (Acceptance 1133, AppLogic 3240, …).make format-check: clean.make codeql: 0 results on changed lines, 0 elsewhere.make mutate SINCE=origin/main BREAK=80, changed lines: Domain 100 % (17/17), Sync 100 % (1/1), AppLogic 87.5 % (42/48). Domain first scored 76.5 %, so the second commit adds boundary and message tests.🤖 Generated with Claude Code