Skip to content

fix(funktionen): show no BIS line on a phone card while the Funktion runs - #672

Merged
DeepDiver1975 merged 1 commit into
mainfrom
fix/668-bis-on-running-cards
Oct 19, 2026
Merged

DeepDiver1975 merged 1 commit into
mainfrom
fix/668-bis-on-running-cards

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #668

Problem

On a phone, Führung & Funktionen shows cards. The card hid its BIS line with ObjectConverters.IsNotNull on ToDisplay, but ToDisplay is "—" while an assignment runs and is never null. So every running card read "BIS —", as if it had ended.

Change

  • RolesView.axaml: the card's BIS line binds to !IsRunning. IsRunning already exists on the row and is notified when To changes.
  • The desktop grid's BIS column is unchanged: "—" in a column is the intended "still running".

Tests

New RolesCardTests.A_running_card_shows_no_bis_line_and_an_ended_card_does, at 412×915 inside IncidentWorkspaceView so the phone container query applies. It has one ended and one running EL, with "Alle Funktionen" on. It failed before the fix: the running card's BIS line was visible.

Screenshots (phone, 412 wide)

Before After
Before After

make clean ci and make format-check pass locally.

🤖 Generated with Claude Code

…runs

The phone card hid its BIS line with IsNotNull on ToDisplay, which is
"—" while an assignment runs and therefore never null. Every running
card read "BIS —", as if it had ended. The card now binds the line to
!IsRunning; the desktop grid's BIS column keeps its "—".

Fixes #668

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 merged commit 26fabb3 into main Oct 19, 2026
11 checks passed
@DeepDiver1975
DeepDiver1975 deleted the fix/668-bis-on-running-cards branch October 19, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Funktionen: every running assignment card on a phone shows "BIS —"

1 participant