Repository navigation
fix(funktionen): show no BIS line on a phone card while the Funktion runs - #672
Merged
Merged
Conversation
…runs The phone card hid its BIS line with IsNotNull on ToDisplay, which is "—" while an assignment runs and therefore never null. Every running card read "BIS —", as if it had ended. The card now binds the line to !IsRunning; the desktop grid's BIS column keeps its "—". Fixes #668 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #668
Problem
On a phone, Führung & Funktionen shows cards. The card hid its BIS line with
ObjectConverters.IsNotNullonToDisplay, butToDisplayis "—" while an assignment runs and is never null. So every running card read "BIS —", as if it had ended.Change
RolesView.axaml: the card's BIS line binds to!IsRunning.IsRunningalready exists on the row and is notified whenTochanges.Tests
New
RolesCardTests.A_running_card_shows_no_bis_line_and_an_ended_card_does, at 412×915 insideIncidentWorkspaceViewso the phone container query applies. It has one ended and one running EL, with "Alle Funktionen" on. It failed before the fix: the running card's BIS line was visible.Screenshots (phone, 412 wide)
make clean ciandmake format-checkpass locally.🤖 Generated with Claude Code