Skip to content

Funktionen: every running assignment card on a phone shows "BIS —" #668

Closed

Description

@DeepDiver1975

Split out of the UX review #262.

Problem

On a phone, every running Funktion card in Führung & Funktionen shows "BIS —", so it reads as ended.

RunningRole.ToDisplay never returns null (RolesViewModel.cs:121):

public string ToDisplay => To is { } t ? Formatting.Timestamp(t) : "—";

The phone card hides the BIS line with ObjectConverters.IsNotNull on ToDisplay (RolesView.axaml:353). That converter is therefore always true. The desktop grid's BIS column (:300) is fine, since "—" in a column is the intended "still running".

Expected

  • A running assignment's card shows VON only; an ended one shows VON and BIS.
  • The grid keeps "—".

Notes

  • Bug fix: write the failing test first. Bind visibility to To (or an IsEnded property on the row view model), and pin it with a test for a running and an ended row.
  • This touches the UI, so the PR needs a before/after screenshot pair at phone width.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinguxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions