Repository navigation
build: pin AnalysisLevel to avoid analyzer drift on SDK bumps - #322
Merged
Merged
Conversation
global.json uses rollForward: latestFeature, so an SDK bump could silently pull in a newer default analyzer rule set; combined with TreatWarningsAsErrors, that turns a routine SDK bump into a build break. Pin <AnalysisLevel> explicitly to the level matching today's SDK (10.0), so adopting new rules becomes a deliberate, reviewable diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9oidCyJ6YmhtCxu9WxGKo Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
build/pin-analysis-level-301
branch
from
September 15, 2026 08:45
2f66749 to
d7df4c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global.jsonusesrollForward: latestFeature, so a routine SDK bump could silently pull in a newer default analyzer rule set. Combined withTreatWarningsAsErrors+AnalysisMode=All, that turns an SDK bump into an unrelated build break.<AnalysisLevel>10.0</AnalysisLevel>inDirectory.Build.props, matching the level implied by the SDK pinned inglobal.jsontoday — preserves current behavior exactly, but future rule-set adoption now requires a deliberate, reviewable bump of this value.Note: this touches the same file as #321 (deterministic builds) — whichever merges first, the other should rebase before merging to avoid a conflict on adjacent lines in
Directory.Build.props.Test plan
dotnet build LageBuch.Desktop.slnf --configuration Release --no-incremental— succeeds, 0 warnings/0 errors, identical to pre-change output (confirms this pins current behavior without changing it)dotnet test LageBuch.Desktop.slnf --configuration Release --no-build— 167 passed, 1 skipped, 0 failed🤖 Generated with Claude Code
https://claude.ai/code/session_01R9oidCyJ6YmhtCxu9WxGKo