You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From the 2026-09-09 code review of main (35d86e1). #287 already adds format-check to CI, read-only CI permissions, the @claude author gate and Dependabot coverage for the nested Directory.Packages.props.
Remaining build and release hygiene items:
Coverage is never collected.coverlet.collector is referenced in Directory.Packages.props but no CI step runs --collect:"XPlat Code Coverage" or publishes a report. Add collection and at least a visible summary (e.g. ReportGenerator markdown into the job summary); a threshold gate can follow later.
Non-deterministic builds. No <Deterministic> / <ContinuousIntegrationBuild> in Directory.Build.props; set ContinuousIntegrationBuild=true when GITHUB_ACTIONS is set so release binaries are reproducible and Source Link paths are mapped.
AnalysisLevel floats with the SDK. With TreatWarningsAsErrors and AnalysisMode=All, a global.json bump can break the build through new analyzer rules. Pin <AnalysisLevel> explicitly and bump it deliberately.
Changelog entries are unenforced.release.yml:147-163 greps the version section out of CHANGELOG.md; a forgotten entry degrades silently into "No changelog entry found" (:157). Add a CI check that a PR touching src/ also touches CHANGELOG.md (or adopt a fragment tool), and mention the changelog in CONTRIBUTING.md / AGENTS.md.
Every .csproj redeclares <Nullable>enable</Nullable> although Directory.Build.props sets it; drop the duplicates.
docker/android-build.Dockerfile downloads the Android command-line tools over HTTPS without a checksum; pin the SHA-256.
Windows/macOS signing remains out of scope here, tracked separately in #208.
One thing surfaced along the way: WorkspaceCollaborationTests.Host_header_reflects_einsatzdaten_saved_in_a_clients_dialog turned out to be a pre-existing flaky test (hit 3 unrelated CI runs during this work) — filed separately as #326.
Activity
DeepDiver1975 commentedon Sep 15, 2026
All items addressed, merged as six focused PRs:
Deterministic/ContinuousIntegrationBuild): build: enable deterministic builds and pin CI to a reproducible build #321AnalysisLevelpin: build: pin AnalysisLevel to avoid analyzer drift on SDK bumps #322<Nullable>enable</Nullable>cleanup: chore: drop redundant Nullable overrides from .csproj files #319Windows/macOS signing remains out of scope here, tracked separately in #208.
One thing surfaced along the way:
WorkspaceCollaborationTests.Host_header_reflects_einsatzdaten_saved_in_a_clients_dialogturned out to be a pre-existing flaky test (hit 3 unrelated CI runs during this work) — filed separately as #326.