Skip to content

Theme: move hard-coded colours into tokens, prepare a light or high-contrast variant #680

Open

Description

@DeepDiver1975

Split out of #605, whose wording half shipped on its own (#678, #679).

Problem

  • App.axaml:5 hard-locks RequestedThemeVariant="Dark".
  • Theme/Tokens.axaml is one flat ResourceDictionary with no ThemeDictionaries: 25 Colors and 26 brushes.
  • Views hard-code hex colours instead of using the tokens.

Direct sun or glare in a vehicle calls for a light or high-contrast variant. Today that is not possible without touching every view.

Survey (main at 95a6845)

There are 114 hard-coded colour values in .axaml outside Tokens.axaml. That count excludes #123 issue references in comments.

File Count
Theme/Styles.axaml 39
Views/CoMessprotokollView.axaml 15
Views/MasterDataEditorView.axaml 12
Views/EtbView.axaml 7
Views/RolesView.axaml 6
Views/TasksView.axaml, Views/ForcesView.axaml 4 each
ScbaView, HomeView, FilesView 3 each
12 more views 1–2 each

The most common values:

Value Uses Token with the same value?
#0F141D 25 none (closest: AppBgColor2 #10141C)
#0C1119 25 none
#241608 10 AmberWashColor
#F87171 8 ErrorColor
#FFFFFF 7 none
#B3070A10 7 none (scrim)
#2A1013 3 ErrorWashColor
#FF0000, #92D050, #FFC000 3 / 3 / 1 none (CO-Messprotokoll status colours)

C# has hex colours only for the CO-Messprotokoll:

  • CoMessprotokollViewModel.cs uses the status colours as string literals.
  • Documents/Sections/CoMessprotokollSection.cs duplicates the Amber, SignalHot and Signal tokens for the PDF. The PDF is not themed, so that part can stay.

Plan

  1. Tokens first, no visual change. Move every hard-coded colour into Tokens.axaml, reusing the existing token where the value matches. Give #0F141D/#0C1119 (panel and grid backgrounds) and the scrim their own tokens. A before/after render of every view should be pixel-identical.
  2. ThemeDictionaries. Move the tokens under Dark, and switch views from StaticResource to DynamicResource where a variant has to swap at runtime.
  3. A light or high-contrast variant, plus a setting to pick it. This needs a palette decision, ideally checked in a vehicle in daylight.

Each step can be its own PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestuxUser interface and usability

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions