Repository navigation
Fork patch: Probe data-var-src media whose value differs from its src - #14
valeriangalliat wants to merge 1 commit into
Conversation
Edit accuracy: accurate 271 (base branch 271), smooth 150 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (1)
|
|
🤖 AI agent: Dropped at sync/2026-11-10. Upstream heygen-com/hyperframes#6501 (v0.8.207) loads the page for One case is left upstream: a default declared in the sub-composition file itself, with no value from the mount. That is reported as heygen-com/hyperframes#7505 with a repro. It is not carried here, because a host can pass the value on the mount instead. The patch's history stays under the |
🤖 AI agent: Arcade fork patch. Do not merge.
This draft shows
patch/probe-var-src-mediaagainstmain, the upstream mirror, so the patch has one page for its diff, its revisions and its reason. Arcade's/hyperframes-updaterebases the branch ontomainand cherry-picks it ontoarcade; this PR is not part of that flow. When a rebuild changes the patch, itsgit range-diffagainst the previoussync/<date>/probe-var-src-mediatag is posted as a comment.Not needed yet and not in
scripts/arcade/patches.json. Arcade doesn't usedata-var-srctoday. This is the prerequisite for moving scene settings onto HyperFrames variables (ARC-17433), and the first candidate to send upstream. Split out of #13.Why
hasVariableBoundMediaonly probes when render-level--variablesset the bound variable. A value from the composition's declared default or a host'sdata-variable-valuesis applied by the runtime in the browser, while extraction reads the staticsrc, so the export shows the fallback clip. HyperFrames' own lint treats a default that differs fromsrcas normal (thesrcis the authored fallback), and its docs presentdata-variable-valuesas the way to give each instance its own values.While inlining, the compiler now stamps
data-hf-var-src-changedon bound<audio>,<video>and<source>when any value in its scope chain differs from the staticsrc: the top-level declared defaults, or any enclosing composition's merged defaults and host values. The trigger probes when it sees the stamp. A bound clip whose value equals itssrcdoesn't load the page. The comparison runs before remote sources are localized, while both still read as authored.Review notes
data-composition-idinside the host's runtime id, which is why a nearest-scope lookup alone misses the host's values.data-hf-auto-start: compiler stamps, probe trigger reads.Verification
htmlCompiler.test.ts: a compiled sub-composition is stamped when the host value differs, stamped when the declared default differs, and left alone when the host value equals thesrc.probeStage.test.ts: stamped versus unstamped bound clip. Upstream'shasVariableBoundMediatests unchanged. 228/228 across both files.tsc,oxfmt,oxlintand lefthook clean.a318cd008plus this change (bundled with Fork patch: Probe untraced media src writes #13 at the time): two temporarydata-var-srcscenes, scene default and host override, pass; both export the stale clip without it.Upstream
No issue or PR filed yet. Strong candidate: it's a gap in HyperFrames' own variables feature.
Drop when
Upstream probes
data-var-srcmedia whose declared default or host value differs from itssrc.Arcade
ARC-17433 · ARC-17431